fix: close #5#6
Open
reaatech wants to merge 1 commit into
Open
Conversation
#5 **Changes across 6 files (30 insertions, 8 deletions):** Added `JsonValue` and `ToolDefinition` types to `packages/core/src/types/index.ts`, replacing lazy `unknown` with precise types in all layers — `CacheEntry.response` uses `JsonValue` (the full JSON-serializable type), `CacheOptions.tools` uses `ToolDefinition[]`, and adapter deserializers (`DynamoDBAdapter`, `QdrantAdapter`) were tightened accordingly. The `CacheEngine.set`/`setBatch` signatures and `app.ts` route handler body were also updated. Genuinely dynamic boundaries (`readBody`, `sendJson`, `safeParseJson`, adapter `Record<string, unknown>` for SDK interop) were left as `unknown` per the issue's own carve-outs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes across 6 files (30 insertions, 8 deletions): Added
JsonValueandToolDefinitiontypes topackages/core/src/types/index.ts, replacing lazyunknownwith precise types in all layers —CacheEntry.responseusesJsonValue(the full JSON-serializable type),CacheOptions.toolsusesToolDefinition[], and adapter deserializers (DynamoDBAdapter,QdrantAdapter) were tightened accordingly. TheCacheEngine.set/setBatchsignatures andapp.tsroute handler body were also updated. Genuinely dynamic boundaries (readBody,sendJson,safeParseJson, adapterRecord<string, unknown>for SDK interop) were left asunknownper the issue's own carve-outs.Closes #5