[DevTools][Protocol Manager] Fixed Protocol Monitor displaying CDP events as "(pending)"#200
Merged
Merged
Conversation
… with no params as "(pending)". CDP events pending doesn't make sense, since events can't be updated after they arrive (since they don't have an id anyway): https://github.com/ChromeDevTools/devtools-frontend/blob/3201a3630665afd30e0a879f4ebeae6fcc4f3806/front_end/panels/protocol_monitor/ProtocolMonitor.ts#L562-L587 Also, events are allowed to have no params based on: * JSON-RPC 2.0 Specification: https://www.jsonrpc.org/specification#:~:text=This%20member%20MAY%20be%20omitted * and CDP Wire Format: https://chromium.googlesource.com/chromium/src/+/master/third_party/blink/public/devtools_protocol/#:~:text=CDP%20is%20designed%20with%20JSON%2DRPC%202.0%20as%20the%20primary%20wire%20format The two events that caught my eye are: * Debugger.resumed https://chromedevtools.github.io/devtools-protocol/tot/Debugger/#event-resumed * and Runtime.executionContextsCleared https://chromedevtools.github.io/devtools-protocol/tot/Runtime/#event-executionContextsCleared Both are expected to be sent without params, however Chrome does send an empty object params for them. I work on the DevTools branch for React Native- https://github.com/facebook/react-native-devtools-frontend We've omitted "params" for these events as per the CDP docs, resulting in "(pending)" displayed in the Protocol Monitor. We thought we made a mistake at first, but it turns out it's just the Protocol Monitor's UI. Screenshots of the issue and the fix are attached in https://issues.chromium.org/issues/440012466. Fixed: 440012466 Change-Id: I34e2472287d66b7cbe9146deae27fac138535425 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6862800 Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Danil Somsikov <dsv@chromium.org> Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
motiz88
approved these changes
Aug 21, 2025
motiz88
left a comment
motiz88
left a comment
There was a problem hiding this comment.
Nit: It's called "Protocol Monitor", not "Protocol Manager".
vzaidman
changed the title
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CDP events pending doesn't make sense, since events can't be updated after they arrive (since they don't have an id anyway): https://github.com/ChromeDevTools/devtools-frontend/blob/3201a3630665afd30e0a879f4ebeae6fcc4f3806/front_end/panels/protocol_monitor/ProtocolMonitor.ts#L562-L587
Also, events are allowed to have no params based on:
The two events that caught my eye are:
Both are expected to be sent without params, however Chrome does send an empty object params for them.
I work on the DevTools branch for React Native-
https://github.com/facebook/react-native-devtools-frontend
We've omitted "params" for these events as per the CDP docs, resulting in "(pending)" displayed in the Protocol Monitor. We thought we made a mistake at first, but it turns out it's just the Protocol Monitor's UI.
Test plan
Upstreaming plan
devtools-frontendrepo following the contribution guide for Meta employees OR contribution guide.