Fix Android Text clipping with Bold text setting by TorinAsakura · Pull Request #57118 · react/react-native

TorinAsakura · 2026-06-08T23:35:46Z

Summary:

Fixes #54931.
Close torin-asakura/workspace#119.

Android's Bold text accessibility setting updates Configuration.fontWeightAdjustment, which makes platform TextView draw text with an adjusted typeface. React Native was measuring Text without that adjustment, so Yoga could allocate a row item width that was too small and the rendered text was clipped.

This passes the current font weight adjustment through Fabric text measurement, prepared text layout, mounted Text spans, and TextInput spans, and applies it to the TextPaint/CustomStyleSpan typeface used for measurement and drawing.

Changelog:

[ANDROID] [FIXED] - Account for Android Bold text font weight adjustment when measuring Text.

Test Plan:

./gradlew :packages:react-native:ReactAndroid:testDebugUnitTest --tests com.facebook.react.views.text.TextLayoutManagerFontWeightAdjustmentTest -Preact.internal.useHermesStable=true
./gradlew :packages:react-native:ReactAndroid:ktfmtCheck -Preact.internal.useHermesStable=true

Reproduced locally before the fix with https://github.com/Lego4m/reproducer-react-native-android-bold-text on Android 16 AVD by toggling font_weight_adjustment between 0 and 300.

Screenshots from #54931:

Bold text off	Bold text on

meta-codesync · 2026-06-10T11:16:27Z

@javache has imported this pull request. If you are a Meta employee, you can view this in D108136049.

javache · 2026-06-11T09:50:34Z

      textEffectRegistry: TextEffectRegistry?,
  ): Spannable {
    var text: Spannable?
    if (attributedString.contains(AS_KEY_CACHE_ID)) {


The new fontWeightAdjustment parameter is only applied when creating a fresh spannable. When AS_KEY_CACHE_ID is present, the previously cached spannable is returned (lines 704-716) without revalidation — carrying stale CustomStyleSpan weights from before the Bold Text setting changed.

javache · 2026-06-11T09:50:48Z

+  }
+
+  @Test
+  fun `plain text paint applies Android font weight adjustment`() {


The test only asserts paint.typeface is non-null. If applyFontWeightAdjustment returned any non-null typeface without applying the weight adjustment (e.g., always Typeface.DEFAULT at weight 400), the test would still pass while the production bug persisted.

javache · 2026-06-12T08:31:08Z

+  @OptIn(UnstableReactNativeAPI::class)
+  fun getOrCreateSpannableForText(
+      assets: AssetManager,
+      fontWeightAdjustment: Int,
+      attributedString: MapBuffer,
+      reactTextViewManagerCallback: ReactTextViewManagerCallback?,
+  ): Spannable =
+      getOrCreateSpannableForText(
+          assets,
+          fontWeightAdjustment,
+          attributedString,
+          reactTextViewManagerCallback,
+          null,
+      )
+
  @OptIn(UnstableReactNativeAPI::class)
  internal fun getOrCreateSpannableForText(
      assets: AssetManager,
      attributedString: MapBuffer,
      reactTextViewManagerCallback: ReactTextViewManagerCallback?,
      textEffectRegistry: TextEffectRegistry?,
+  ): Spannable =


These are internal functions, so we don't need to keep all the overloads for backwards compatibility.

javache · 2026-06-12T08:33:28Z

Avoid duplication, use an early return

Suggested change

val cachedSpannable = checkNotNull(tagToSpannableCache[cacheId])

if (cachedSpannable.fontWeightAdjustment == fontWeightAdjustment) {

return cachedSpannable.spannable

}

return createSpannableFromAttributedString(

assets,

fontWeightAdjustment,

attributedString.getMapBuffer(AS_KEY_FRAGMENTS),

reactTextViewManagerCallback,

null,

textEffectRegistry,

)

javache · 2026-06-12T08:33:53Z

+            createSpannableFromAttributedString(
+                assets,
+                fontWeightAdjustment,
+                attributedString.getMapBuffer(AS_KEY_FRAGMENTS),
+                reactTextViewManagerCallback,
+                null,
+                textEffectRegistry,
+            )


Should we write back to the cache?

javache · 2026-06-12T08:39:27Z

    if (attributedString.contains(AS_KEY_CACHE_ID)) {
-      paint = text.getSpans(0, 0, ReactTextPaintHolderSpan::class.java)[0].textPaint
+      val textPaintHolderSpans = text.getSpans(0, 0, ReactTextPaintHolderSpan::class.java)
+      paint =


Why the change here? Recreating paint here may have a performance impact - why can't we apply the adjustment when creating the ReactTextPaintHolderSpan?

javache · 2026-06-12T08:39:54Z

+  private const val FONT_WEIGHT_MIN = 1
+  private const val FONT_WEIGHT_MAX = 1000


Use FontStyle.FONT_WEIGHT_MIN/MAX

javache · 2026-06-12T08:40:36Z

+            .java
+            .getDeclaredMethod(
+                "updateTextPaint",
+                TextPaint::class.java,


Don't use reflection, mark the method internal instead

javache · 2026-06-12T08:42:10Z

      reactTextViewManagerCallback: ReactTextViewManagerCallback?,
      attachmentsPositions: FloatArray?,
      textEffectRegistry: TextEffectRegistry? = null,
+  ): Long =


Internal method - don't add overloads

…-measurement

fix: account for Android font weight adjustment in text measurement

63c34a8

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 8, 2026

facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jun 8, 2026

javache requested changes Jun 11, 2026

View reviewed changes

TorinAsakura added 2 commits June 11, 2026 14:51

fix: refresh cached spannables for font weight changes

3ee9e05

test: assert adjusted text paint typeface

210ecb9

javache requested changes Jun 12, 2026

View reviewed changes

TorinAsakura added 7 commits June 12, 2026 17:01

fix: remove spannable internal overloads

9d33a00

fix: return early for matching spannable cache

94c2f83

fix: update spannable cache after weight changes

07bde8f

fix: cache adjusted text paint holders

1c47c10

fix: use FontStyle weight bounds

e71870f

test: call text paint update directly

d905a71

fix: remove text layout internal overloads

97b3430

TorinAsakura force-pushed the fix/android-bold-text-measurement branch from 807447e to 97b3430 Compare June 12, 2026 15:05

Merge remote-tracking branch 'origin/main' into fix/android-bold-text…

8cae4d5

…-measurement

		private const val FONT_WEIGHT_MIN = 1
		private const val FONT_WEIGHT_MAX = 1000

Conversation

TorinAsakura commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan:

Uh oh!

meta-codesync Bot commented Jun 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TorinAsakura Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TorinAsakura Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TorinAsakura Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TorinAsakura Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TorinAsakura Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TorinAsakura Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TorinAsakura Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TorinAsakura Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TorinAsakura Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TorinAsakura commented Jun 8, 2026 •

edited

Loading

TorinAsakura Jun 11, 2026 •

edited

Loading

TorinAsakura Jun 11, 2026 •

edited

Loading

TorinAsakura Jun 12, 2026 •

edited

Loading

TorinAsakura Jun 12, 2026 •

edited

Loading

TorinAsakura Jun 12, 2026 •

edited

Loading

TorinAsakura Jun 12, 2026 •

edited

Loading

TorinAsakura Jun 12, 2026 •

edited

Loading

TorinAsakura Jun 12, 2026 •

edited

Loading

TorinAsakura Jun 12, 2026 •

edited

Loading