Skip to content

Register Android pointer capture events#57176

Closed
yaminyassin wants to merge 1 commit into
react:mainfrom
yaminyassin:android-pointer-capture-view-config
Closed

Register Android pointer capture events#57176
yaminyassin wants to merge 1 commit into
react:mainfrom
yaminyassin:android-pointer-capture-view-config

Conversation

@yaminyassin

@yaminyassin yaminyassin commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary:

The PointerEventsProcessor C++ pointer-events implementation already supports pointer capture and can emit topGotPointerCapture and topLostPointerCapture. TouchEventEmitter has handlers for both events.

Android base view config was not registering the events:

  • onGotPointerCapture / onGotPointerCaptureCapture
  • onLostPointerCapture / onLostPointerCaptureCapture

This adds the missing Android registrations and adds an EventDispatching integration test covering capture and bubble dispatch for both pointer capture events.

Changelog:

[Android] [Fixed] - Register pointer capture event handlers in the Android base view config

Test Plan:

Added coverage in EventDispatching-itest.js for onGotPointerCapture, onGotPointerCaptureCapture, onLostPointerCapture, and onLostPointerCaptureCapture.

git diff --check main...HEAD

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 11, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jun 11, 2026
@meta-codesync

meta-codesync Bot commented Jun 11, 2026

Copy link
Copy Markdown

@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D108321784.

@Abbondanzo

Copy link
Copy Markdown
Contributor

@yaminyassin Android is not yet using the C++ pointer events implementation so this view config change is redundant. Happy to accept just the fantom tests for now though

@yaminyassin

Copy link
Copy Markdown
Contributor Author

@Abbondanzo I'm taking a shot at implementing the missing cpp layer for pointer events, this pr should have been opened as draft my bad 🥲.

I'll ping you when the bigger change is ready to look at, and I'll reach out if questions come up along the way.

@yaminyassin yaminyassin marked this pull request as draft June 12, 2026 16:11

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync Bot closed this in 74382ca Jun 12, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Jun 12, 2026
@meta-codesync

meta-codesync Bot commented Jun 12, 2026

Copy link
Copy Markdown

@Abbondanzo merged this pull request in 74382ca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants