Add legacy_uigraphics_functions rule#6269
Merged
SimplyDanny merged 1 commit intorealm:mainfrom Apr 16, 2026
Merged
Conversation
Generated by 🚫 Danger |
SimplyDanny
requested changes
Oct 2, 2025
Collaborator
|
I wasn't actually aware of Edit: I remove the helper in #6271 so that visitor and rewrite can directly be used. |
|
I have created an analyzer rule that reports all uses of any deprecated declarations (marked with The types mentioned in this PR all seem like they should be detectable by my analyzer rule. I used AI to create it, as I don't know SourceKitten, SourceKit, SwiftLint APIs, etc. I am cleaning up the code now, and will try to learn SourceKitten, etc. by reading the code. Once it's cleaned up, would you review it? If so, I assume I should make a new issue for it (as I haven't found an existing one), and move this discussion to that issue. Would it supersede this rule? What configuration options would you prefer? What names would you prefer be used? e.g., should it be the I assume it would be helpful to filter out deprecated uses where the replacement is not available for the current project (e.g., based on the minimum supported platform versions), but I haven't determined if it's easy to obtain that info. If such filtering were provided, should the rule be able to read the minimum platform versions from a Should there be some way to globally ignore uses of specified declarations? If so, should they be specified via strings like "URL.init(fileURLWithPath:isDirectory:)"? Should the rule try to detect the replacement declaration, and output its details in the violation message (I assume it will be too difficult to apply fixes via Should the rule detect deprecated declarations via additional mechanisms? e.g., should it support manual replacement mappings (e.g., Etc. |
Collaborator
Both rules (and more existing ones) can live side by side. As Analyzer rules run very slow, the syntax-based rules are faster alternatives that might be sufficient for some/most users. Let's chat about the other questions you have in the PR that you are about to create. A dedicated issue is not needed. 😉 |
|
Will do. I will create a draft PR later today if you want to look over the code before I have a chance to completely understand SourceKit & ensure that the PR is up to snuff. I'll update the code & switch to a normal PR once I've had the chance to completely look through it all. I'll also keep everything barebones to get feedback first, then add bells & whistles once everything has been discussed. |
|
FYI: the AI code was worse than I expected. I need to completely redo most of it, and to research beforehand. I will get back to it in a bit, then submit a PR once it's much better. |
SimplyDanny
force-pushed
the
legacy_uigraphics_functions
branch
from
90f71ca to
0f65858
Compare
SimplyDanny
approved these changes
Apr 15, 2026
SimplyDanny
force-pushed
the
legacy_uigraphics_functions
branch
from
0f65858 to
6105e44
Compare
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
SimplyDanny
force-pushed
the
legacy_uigraphics_functions
branch
from
6105e44 to
d0539eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new
legacy_uigraphics_functionsrule to encourage the use of modern UIGraphicsImageRenderer instead of legacy UIGraphics{Begin|End}ImageContext.The modern replacement is safer, cleaner, Retina-aware and more performant.
The legacy API is deprecated
Resolves #6268