Repository navigation
fix: move xlsx to devDependencies — npm 12 refuses the CDN tarball (#193) - #194
Merged
Merged
Conversation
npm 12 refuses the CDN tarball spec by default, so every consumer's install failed. The built files are identical either way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #193.
xlsxwas a runtime dependency onhttps://cdn.sheetjs.com/xlsx-0.20.3/xlsx-0.20.3.tgz. npm 12 refuses URL specs by default (allow-remote=none), so installing anything that depends on this package fails —npx mulmoclaude@2.8.0does. SheetJS is already bundled intodist/vue.js/dist/vue.cjs(it is not invite.config.ts'sexternal), so consumers never load the installed copy.xlsxmoves todevDependencies(still needed to build). Same spec.tests/core/test_packageManifest.ts:dependencies/peerDependencies/optionalDependenciesmust not hold a URL, git,file:orowner/repospec.plans/fix-193-xlsx-dev-dependency.md.Items to Confirm / Review
dist/built from the old and the newpackage.jsonis byte-identical (diff -r), so nothing shipped changes except the manifest.npm packtarball installs with npm 12.0.2 and an empty user config;xlsxis not installed;.,./vueand./coreimport, and./vuealso loads viarequire.package.json(namingxlsx) and passes on this one. typecheck, lint, format:check, build,yarn testandyarn test:enginepass locally.main; 4.3.1 from a branch off the@gui-chat-plugin/spreadsheet@4.3.0tag with the same change, published with--tagsolateststays on 5.x.mulmoclaude@2.8.0depends on^4.3.0, so 4.3.1 fixes it without a mulmoclaude release.User Prompt
xlsxout of the runtime dependencies so npm 12 can install it. Check first thatxlsxis not used at runtime and nothing breaks.work in mulmoclaude2
🤖 Generated with Claude Code