fix(daemon): require consumer auth for sensitive gRPC RPCs (H8/H10)#76
Merged
Conversation
Fail closed on non-loopback binds without consumers, gate secrets/config/ providers/shutdown/chat/MCP with capabilities, and compare tokens with crypto.timingSafeEqual. Document the model (DR-036) and add unit/E2E coverage.
Rebase onto main kept Zod as DR-036. Consumer auth is DR-037. Require chat capability for SummarizeSession, and only warn about open auth when consumers are actually empty.
Collaborator
|
Maintainer bring-up on
Waiting on CI, then approve if green. |
cidrblock
approved these changes
Jul 17, 2026
cidrblock
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: merge-ready
H8/H10 consumer auth looks solid: fail-closed non-loopback bind, capability gates, timing-safe tokens.
Maintainer tip 0380f5f rebased onto main, renumbered to DR-037, gates SummarizeSession with chat, and fixes the open-auth warning. CI green. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
consumers(unless--allow-open-auth/--insecure).consumersis configured, gate sensitive RPCs withx-abbenay-token+ capabilities (secrets, config, providers, shutdown, chat, mcp_register, inline_policy).crypto.timingSafeEqual.Changes
consumer-auth.tsabbenay-service.tschatdaemon.ts/index.tsTest plan
main(post-fix(daemon): validate HTTP API bodies and config write paths (H4/H5) #75); DR-037 (not 032/036 collision)consumer-auth.test.ts— timing-safe tokens, fail-closed bind, capability matrixchatFix: https://redhat.atlassian.net/browse/AAP-82832