Downstream/carry: Retry on Conflict in createResource, deleteResource#56
Downstream/carry: Retry on Conflict in createResource, deleteResource#56andreaskaris wants to merge 1 commit into
Conversation
fix(helm): Retry Conflict error for createResource, deleteResource kubernetes might at any time throw 409 Conflict Error codes. Clients are supposed to retry when this happens. As an example, see kubernetes/issues/67761 where such an issues might happen when the cluster manipulates a projects's ResourceQuotas. Catch such Conflict Errors on createResource and deleteResource and retry before giving up. Due to the more complex logic and focus on kubernetes/issues/67761, this patch purposefully omits possibly needed changes to updateResource and instead defers them to another patch if required in the future. Closes issue helm#9710 Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1934604 Signed-off-by: Andreas Karis <ak.karis@gmail.com>
|
Hi @andreaskaris. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andreaskaris The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
fix(helm): Retry Conflict error for createResource, deleteResource
kubernetes might at any time throw 409 Conflict Error codes. Clients
are supposed to retry when this happens. As an example, see
kubernetes/issues/67761 where such an issues might happen when the
cluster manipulates a projects's ResourceQuotas.
Catch such Conflict Errors on createResource and deleteResource and
retry before giving up. Due to the more complex logic and focus on
kubernetes/issues/67761, this patch purposefully omits possibly
needed changes to updateResource and instead defers them to another
patch if required in the future.
Closes issue helm#9710
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1934604
Signed-off-by: Andreas Karis ak.karis@gmail.com
What this PR does / why we need it:
Special notes for your reviewer:
If applicable: