Skip to content

Downstream/carry: Retry on Conflict in createResource, deleteResource#56

Open
andreaskaris wants to merge 1 commit into
redhat-developer:release-3.9from
andreaskaris:issue9710-downstream
Open

Downstream/carry: Retry on Conflict in createResource, deleteResource#56
andreaskaris wants to merge 1 commit into
redhat-developer:release-3.9from
andreaskaris:issue9710-downstream

Conversation

@andreaskaris
Copy link
Copy Markdown

fix(helm): Retry Conflict error for createResource, deleteResource

kubernetes might at any time throw 409 Conflict Error codes. Clients
are supposed to retry when this happens. As an example, see
kubernetes/issues/67761 where such an issues might happen when the
cluster manipulates a projects's ResourceQuotas.

Catch such Conflict Errors on createResource and deleteResource and
retry before giving up. Due to the more complex logic and focus on
kubernetes/issues/67761, this patch purposefully omits possibly
needed changes to updateResource and instead defers them to another
patch if required in the future.

Closes issue helm#9710

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1934604
Signed-off-by: Andreas Karis ak.karis@gmail.com

What this PR does / why we need it:

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

fix(helm): Retry Conflict error for createResource, deleteResource

kubernetes might at any time throw 409 Conflict Error codes. Clients
are supposed to retry when this happens. As an example, see
kubernetes/issues/67761 where such an issues might happen when the
cluster manipulates a projects's ResourceQuotas.

Catch such Conflict Errors on createResource and deleteResource and
retry before giving up. Due to the more complex logic and focus on
kubernetes/issues/67761, this patch purposefully omits possibly
needed changes to updateResource and instead defers them to another
patch if required in the future.

Closes issue helm#9710

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1934604
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 23, 2022

Hi @andreaskaris. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from baijum and sbose78 June 23, 2022 09:37
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andreaskaris
To complete the pull request process, please assign pmacik after the PR has been reviewed.
You can assign the PR to them by writing /assign @pmacik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant