feat(intelligent-assistant): add inline rename for notebook resources#3834
Conversation
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3834 +/- ##
==========================================
+ Coverage 56.26% 56.29% +0.03%
==========================================
Files 2499 2500 +1
Lines 96058 96173 +115
Branches 26644 26665 +21
==========================================
+ Hits 54047 54141 +94
- Misses 41683 41704 +21
Partials 328 328
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 10:19 AM UTC · Completed 10:26 AM UTC |
Review — approvePR: #3834 — feat(intelligent-assistant): add inline rename for notebook resources SummaryThis PR adds inline rename functionality for notebook document resources. The implementation is well-structured, spanning backend (PATCH endpoint with conflict detection and rollback) and frontend (inline TextInput with extension separation, conflict validation, keyboard handling). Test coverage is thorough across all layers. What looks good
Findings1. Non-atomic rename relies on delete-then-create with a brief inconsistency window
2. No maximum length or character validation on new title
The PATCH endpoint validates that 3. Rename tooltip and kebab item shown unconditionally
The "Double-click to rename" tooltip and the "Rename" kebab dropdown item are always rendered, regardless of whether VerdictThe implementation is solid, well-tested, and follows established patterns in the codebase. The non-atomic rename is an inherent API limitation handled with appropriate rollback protection. The PR is safe to merge. Labels: PR adds a PATCH endpoint and inline rename UI within the intelligent-assistant workspace |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
|
|
@JslYoon Please review the backend changes. |
HusneShabbir
left a comment
HusneShabbir
left a comment
There was a problem hiding this comment.
I noticed a slight delay in the file renaming process. It seems the non-atomic rename relies on a delete-then-create flow, which introduces a brief inconsistency window. I'd encourage @JslYoon to take a closer look and suggest any improvements if applicable.
Also, could you please address comments 1 and 2 from the Fullsend review? Specifically:
- 1: The non-atomic rename (
delete→create) introduces a brief inconsistency window. - 2: Very long title names don't add much value; it would be better to consider adding a length cap.
Screen.Recording.2026-07-20.at.1.24.16.PM.mov
2 participants
Description
Adds inline rename capability for notebook documents (resources) in the DocumentSidebar. Users can double-click a filename or select "Rename" from the kebab menu to edit the document name inline using a PatternFly TextInput. The file extension is shown as a static suffix and cannot be accidentally modified. Frontend conflict validation prevents renaming to an existing document name with real-time error feedback. A new backend PATCH endpoint handles the rename with rollback protection if the vector store re-creation fails.
UI after changes
S_.2026-07-19.at.3.04.32.PM.mov
S_.2026-07-19.at.3.05.43.PM.mov
Fixed
✔️ Checklist