Skip to content

Add setting to disable automatic schema detection for matching YAML files and add "No JSON Schema" to schema picker#1248

Merged
datho7561 merged 2 commits into
redhat-developer:mainfrom
shin19991207:schemaDetectionDisableFor
May 13, 2026
Merged

Add setting to disable automatic schema detection for matching YAML files and add "No JSON Schema" to schema picker#1248
datho7561 merged 2 commits into
redhat-developer:mainfrom
shin19991207:schemaDetectionDisableFor

Conversation

@shin19991207
Copy link
Copy Markdown
Member

@shin19991207 shin19991207 commented May 12, 2026

What does this PR do?

What issues does this PR fix or reference?

Fixes #245
Fixes #991

Is it tested? How?

  • New automated tests
  • Manual testing

Signed-off-by: Morgan Chang <shin19991207@gmail.com>
@shin19991207 shin19991207 requested a review from datho7561 as a code owner May 12, 2026 21:05
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
@shin19991207 shin19991207 changed the title Add setting to disable automatic schema detection for matching YAML files Add setting to disable automatic schema detection for matching YAML files and add "No JSON Schema" to schema picker May 13, 2026
Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works well!

Found some weird stuff in the schema picker that's probably unrelated and can be handled in a later PR:

  1. If a YAML file has two schemas, there's a weird stack overflow on the server somewhere when trying to open the picker.
  2. The picker doesn't appear in docker-compose.yaml files; I'm guessing the picker is registered for YAML files, and docker compose files are considered as a different language. I don't know if it's worth addressing this, since the schema should be correct?

@datho7561 datho7561 merged commit 045b21f into redhat-developer:main May 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schema: Add "No Schema" to list of JSON schemas Disable schema detection for certain files

2 participants