Harden and pin GHA actions by digest#184
Merged
Merged
Conversation
caxu-rh
changed the title
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThis PR pins third-party GitHub Actions in CI and build workflows to specific commit SHAs instead of floating major-version tags: ChangesGitHub Actions Security Pinning
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build-main.yml:
- Around line 16-19: The workflow's setup-go step (the step using
actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c with id: go) currently
leaves the Go module cache enabled; add cache: false to that step in
build-main.yml (and mirror the same change in build-release.yml) so the setup-go
action does not persist or restore a Go/module download cache when building and
publishing images.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c5e8d589-9eef-46d2-bbb9-c9b999b88957
📒 Files selected for processing (3)
.github/workflows/build-main.yml.github/workflows/build-release.yml.github/workflows/ci.yml
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build-release.yml:
- Around line 16-19: Remove the unsupported "cache: false" parameter from the
actions/checkout step (the line paired with uses:
actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10) so the checkout
action only includes supported keys (e.g., keep persist-credentials: false if
desired); do not add caching here—use language-specific setup/cache actions
(like actions/setup-go or actions/cache) for caching instead.
- Around line 21-24: Add the explicit cache: false setting to the
actions/setup-go step in the workflow to match build-main.yml and prevent cache
poisoning; locate the setup-go invocation (the step using
actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c with id: go and
go-version-file: go.mod) and add cache: false under its with: block so the step
disables the default caching behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 276435a5-7ec5-43ed-9549-3adb9181b0c2
📒 Files selected for processing (3)
.github/workflows/build-main.yml.github/workflows/build-release.yml.github/workflows/ci.yml
🚧 Files skipped from review as they are similar to previous changes (2)
- .github/workflows/build-main.yml
- .github/workflows/ci.yml
Signed-off-by: Caleb Xu <caxu@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit