Fix cp handling for deleting destination entries#237
Merged
Conversation
atimin
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix.
What was changed?
cpstarts and mark entries already inDeletingstate as failed instead of trying to write into them--from-lastentry start overrides based on a single destination entry listing pass409 Conflictresponses by re-checking destination entry status and failing the entry when it has transitioned toDeleting0.12.2and document the fix inCHANGELOG.mdRelated issues
cpagainst deleting destination entries silently counting all records as skipped after backend409 ConflictresponsesDoes this PR introduce a breaking change?
No.
Other information:
Validation performed:
cargo test --quiet --no-runcargo test --quiet test_build_blocked_entry_errors_marks_deleting_entriescargo test --quiet test_entry_tree_shows_failure_for_entries_without_copied_recordscargo test --quiet test_message_shows_skipped_only_when_non_zeroNote: the broader
cptest suite in this environment depends on the local ReductStore test server and was not runnable here without that service.