Add replication destination prefix support#247
Merged
Conversation
Constraint: API 1.21 exposes destination prefixes and removes the deprecated replication each_s field. Rejected: Keep reduct-rs 1.20 from crates.io | its replication model cannot serialize the new prefix. Confidence: high Scope-risk: moderate Directive: Return reduct-rs to the registry release after the API 1.21 SDK is published. Tested: 192 locked tests against reduct/store:main; cargo build --locked; cargo fmt --all -- --check; cargo package --locked --allow-dirty --no-verify; built CLI create/show/update smoke Not-tested: Cross-target release builds; strict Clippy is already non-clean across untouched code
atimin
requested changes
Jul 13, 2026
atimin
left a comment
atimin
left a comment
Member
There was a problem hiding this comment.
Hi @ychampion ,
thank you very much for your contribution! The PR is perfect, just update docs as I mentioned in the change request.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #246
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature.
What was changed?
--prefixto replica create and update commands.replica show.reduct-rsrevision.Related issues
Does this PR introduce a breaking change?
Yes. Replica create and update no longer expose the deprecated
--each-soption removed from API v1.21. Other commands that use--each-sare unchanged.Other information:
Validation performed:
RS_API_TOKEN=TOKEN cargo test --locked -- --test-threads=1(192 passed againstreduct/store:main)cargo build --lockedcargo fmt --all -- --checkcargo package --locked --allow-dirty --no-verify