Conversation
TestAsyncRefreshCompletions intermittently timed out on CI: under `go test -race` on a loaded runner the PTY/render pipeline is starved (race instrumentation adds several-fold overhead), and the shared 3s screen-wait ceiling was too tight for the async-refresh tests, which wait for a background goroutine to grow the menu. Locally the test settles in well under 2s. The pollers return the instant the awaited content appears, so a larger ceiling never slows a passing test -- it only caps how long we wait before declaring failure. Raise it to 15s. No production code is affected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
=======================================
Coverage 38.33% 38.33%
=======================================
Files 59 59
Lines 9516 9516
=======================================
Hits 3648 3648
Misses 5785 5785
Partials 83 83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Goworkflow failed on themasterpush for #107 (the v1.2.2 merge):This is unrelated to the merged change (the skip-csi-sequence command). It's a flaky timeout in the PTY-based async-refresh test: under
go test -raceon a loaded GitHub runner, the PTY/render pipeline is starved (race instrumentation adds several-fold overhead), and the shared 3sscreenWaitTimeoutwas too tight for tests that wait on a background goroutine growing the completion menu. The same code passed on the PR run; locally the test settles in well under 2s.Fix
Raise
screenWaitTimeout(the shared PTY screen-poll ceiling) from 3s to 15s. The pollers return the instant the awaited content appears, so a larger ceiling never slows a passing test — it only caps how long we wait before declaring failure. No production code is touched.Verification
TestAsyncRefreshCompletionsnow completes in ~0.4s under-race.internal/displaysuite under-race5× — all green (~9s each).go vetandgolangci-lintclean.🤖 Generated with Claude Code