Skip to content

Split only once to allow for colons in partition name#3678

Closed
sschmittgwdg wants to merge 1 commit into
reframe-hpc:developfrom
sschmittgwdg:fix_allow_colon_in_partition_name
Closed

Split only once to allow for colons in partition name#3678
sschmittgwdg wants to merge 1 commit into
reframe-hpc:developfrom
sschmittgwdg:fix_allow_colon_in_partition_name

Conversation

@sschmittgwdg

Copy link
Copy Markdown

No description provided.

@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.96%. Comparing base (c6a4b9b) to head (238be36).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3678   +/-   ##
========================================
  Coverage    91.96%   91.96%           
========================================
  Files           62       62           
  Lines        13769    13769           
========================================
  Hits         12662    12662           
  Misses        1107     1107           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vkarak

vkarak commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

I am bit reluctant accepting this PR: : is the separator of a system and partition throughout the framework. I would instead suggest that the framework should deny partitions with : and avoid crashes. In your case, why is : important in the name of the partition?

@sschmittgwdg

Copy link
Copy Markdown
Author

It's not important. I started having ReFrame's partitions named as our slurm partitions and the latter had a :. Denying : in ReFrame's partitions is fine for me.

@vkarak

vkarak commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Closing this and I opened an issue: #3681

@vkarak vkarak closed this Jun 11, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in ReFrame Backlog Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants