Enable Garrison button only when it should#140
Open
SouDescolado wants to merge 1 commit into
Open
Conversation
Fixes rekterakathom#135 As @hirsja95 mentioned, the logic was flawed. It was: Checking if the player dont have a base AND Checking if a player is close to a base. So if the player neither has a base nor is close to one, would return False, and since the ! is outside the parenthesis, it would make the check return True, making the button visible. Ironically, it would disable the garrisson button if the player had a base and was close to it
Author
At backpack shop in Kore, Altis. Garrison button not active. 
At Kore Base. Garrison button active. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #135
As @hirsja95 mentioned, the logic was flawed.
It was:
Checking if the player dont have a base
AND
Checking if a player is close to a base.
So if the player neither has a base nor is close to one, would return False, and since the ! is outside the parenthesis, it would make the check return True, making the button visible.
Ironically, it would disable the garrisson button if the player had a base and was close to it