Skip to content

GAMS compatible write.gdx#2361

Merged
tonnrueter merged 6 commits into
remindmodel:developfrom
tonnrueter:dev/tall-not-period
Jun 9, 2026
Merged

GAMS compatible write.gdx#2361
tonnrueter merged 6 commits into
remindmodel:developfrom
tonnrueter:dev/tall-not-period

Conversation

@tonnrueter

Copy link
Copy Markdown
Contributor

Purpose of this PR

Fixes execute_load issues with p15_climate.gdx by switching from IAMC to REMIND native labels. Need to drop region index column from dimCols, rename period to tall

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ◻️ GAMS Code
  • ☑️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ☑️ Bug fix
  • ◻️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ◻️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

  • Runs with these changes are here:
  • Comparison of results (what changes by this PR?):

Tonn Rüter and others added 4 commits June 3, 2026 23:17
Fixes `execute_load` issues with `p15_climate.gdx` by switching from IAMC to REMIND native labels. Need to drop `region` index column, rename `period` to `tall`
@tonnrueter tonnrueter self-assigned this Jun 5, 2026
@tonnrueter tonnrueter requested review from fbenke-pik and fpiontek June 5, 2026 00:38
Comment thread renv/activate.R
section <- header(sprintf("Bootstrapping renv %s", friendly))
catf(section)

# ensure the target library path exists; required for file.copy(..., recursive = TRUE)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the changes in this file intentional? If they were done automatically and are not part of your work, I'd say don't commit them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

activate.R updates during make test

@fbenke-pik fbenke-pik self-requested a review June 9, 2026 08:40
@tonnrueter tonnrueter force-pushed the dev/tall-not-period branch from cf99458 to 75b3128 Compare June 9, 2026 10:05

@fpiontek fpiontek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passt so, das sollte die Probleme lösen.

@tonnrueter tonnrueter merged commit 23c3ab7 into remindmodel:develop Jun 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants