Skip to content

Distribute input file with land use air pollutants to the reporting folder#2368

Merged
dklein-pik merged 1 commit into
remindmodel:developfrom
dklein-pik:ap
Jun 11, 2026
Merged

Distribute input file with land use air pollutants to the reporting folder#2368
dklein-pik merged 1 commit into
remindmodel:developfrom
dklein-pik:ap

Conversation

@dklein-pik

Copy link
Copy Markdown
Contributor

Type of change

Parts concerned

  • ◻️ GAMS Code
  • ☑️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ☑️ Bug fix
  • ◻️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ◻️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

…ants (AirPollutantsMAgPIE.cs4r) to the reporting folder
Copilot AI review requested due to automatic review settings June 11, 2026 12:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the reporting input distribution list to include the land-use air pollutants file so it can be placed into the reporting folder as part of the existing “core/input/reporting” file set.

Changes:

  • Add AirPollutantsMAgPIE.cs4r to the list of reporting-related files to distribute.
  • Normalize the list formatting so each entry is a plain filename line (no stray indentation/formatting artifacts).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LaviniaBaumstark LaviniaBaumstark left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@dklein-pik dklein-pik merged commit 962a1a8 into remindmodel:develop Jun 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants