Skip to content

Fix formatting of trailing comments before equals#8444

Merged
cknitt merged 1 commit into
rescript-lang:masterfrom
fhammerschmidt:fix-8443
May 26, 2026
Merged

Fix formatting of trailing comments before equals#8444
cknitt merged 1 commit into
rescript-lang:masterfrom
fhammerschmidt:fix-8443

Conversation

@fhammerschmidt
Copy link
Copy Markdown
Member

Fixes #8443

@fhammerschmidt fhammerschmidt requested review from cknitt and shulhi May 26, 2026 08:45
@fhammerschmidt fhammerschmidt changed the title Fix formattin of trailing comments before equals Fix formatting of trailing comments before equals May 26, 2026
@fhammerschmidt
Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/syntax_tests/data/printer/comments/expected/valueBindings.res.txt Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.90%. Comparing base (de28ae6) to head (daf6712).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
compiler/syntax/src/res_printer.ml 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8444      +/-   ##
==========================================
- Coverage   59.92%   59.90%   -0.02%     
==========================================
  Files         373      373              
  Lines       54210    54231      +21     
==========================================
+ Hits        32487    32489       +2     
- Misses      21723    21742      +19     
Files with missing lines Coverage Δ
compiler/syntax/src/res_printer.ml 81.47% <83.33%> (-0.02%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 26, 2026

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@8444

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@8444

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@8444

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@8444

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@8444

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@8444

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@8444

commit: daf6712

@cknitt cknitt merged commit 5487af2 into rescript-lang:master May 26, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

format can change multiline strings

3 participants