Skip to content

Add spotless plugin and fix grammar issues #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thboileau wants to merge 30 commits into
base: 2.7
Choose a base branch
from

Taken into account PR review comment

03c15f8
Select commit
Loading
Failed to load commit list.
Open

Add spotless plugin and fix grammar issues #1503

Taken into account PR review comment
03c15f8
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 7, 2026 in 54s

Quality Gate failed

Failed conditions
1 Security Hotspot
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 569 in org.restlet/src/main/java/org/restlet/engine/util/StringUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code in order to not assign to this loop counter from within the loop body. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06MwAULQrmbX5-9NEi&open=AZ06MwAULQrmbX5-9NEi&pullRequest=1503

Check warning on line 87 in org.restlet/src/main/java/org/restlet/data/CookieSetting.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Constructor has 8 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06MwEKLQrmbX5-9NFW&open=AZ06MwEKLQrmbX5-9NFW&pullRequest=1503

Check warning on line 153 in org.restlet/src/main/java/org/restlet/data/ChallengeResponse.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Constructor has 14 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06MwGgLQrmbX5-9NFr&open=AZ06MwGgLQrmbX5-9NFr&pullRequest=1503

Check warning on line 122 in org.restlet/src/main/java/org/restlet/engine/local/Entity.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 73 to 64, Complexity from 30 to 14, Nesting Level from 5 to 2, Number of Variables from 22 to 6. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ1er9yArHfHDGLiFlJg&open=AZ1er9yArHfHDGLiFlJg&pullRequest=1503

Check warning on line 51 in org.restlet/src/main/java/org/restlet/representation/ObjectRepresentation.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make VARIANT_OBJECT_XML_SUPPORTED a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06MwIaLQrmbX5-9NF6&open=AZ06MwIaLQrmbX5-9NF6&pullRequest=1503

Check failure on line 216 in org.restlet/src/main/java/org/restlet/engine/converter/DefaultConverter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 29 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06MwBwLQrmbX5-9NEv&open=AZ06MwBwLQrmbX5-9NEv&pullRequest=1503

Check warning on line 218 in org.restlet/src/main/java/org/restlet/engine/ssl/DefaultSslContextFactory.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ1eSi_fS1usNdOdyPkR&open=AZ1eSi_fS1usNdOdyPkR&pullRequest=1503

Check failure on line 81 in org.restlet.ext.json/src/main/java/org/restlet/ext/json/JsonConverter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06MwXJLQrmbX5-9NHs&open=AZ06MwXJLQrmbX5-9NHs&pullRequest=1503

Check warning on line 52 in org.restlet.ext.xml/src/main/java/org/restlet/ext/xml/XmlRepresentation.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This class has 6 parents which is greater than 5 authorized. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06MwZNLQrmbX5-9NH6&open=AZ06MwZNLQrmbX5-9NH6&pullRequest=1503

Check failure on line 122 in org.restlet/src/main/java/org/restlet/engine/local/Entity.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 73 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06Mv4YLQrmbX5-9NDg&open=AZ06Mv4YLQrmbX5-9NDg&pullRequest=1503

Check failure on line 113 in org.restlet/src/main/java/org/restlet/engine/resource/ClientInvocationHandler.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 136 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06Mv7YLQrmbX5-9ND7&open=AZ06Mv7YLQrmbX5-9ND7&pullRequest=1503

Check warning on line 56 in org.restlet/src/main/java/org/restlet/representation/ObjectRepresentation.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "VARIANT_OBJECT_BINARY_SUPPORTED" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06MwIaLQrmbX5-9NF_&open=AZ06MwIaLQrmbX5-9NF_&pullRequest=1503

Check warning on line 45 in org.restlet/src/main/java/org/restlet/engine/util/ChildContext.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06MwAxLQrmbX5-9NEp&open=AZ06MwAxLQrmbX5-9NEp&pullRequest=1503

Check warning on line 1024 in org.restlet/src/main/java/org/restlet/data/Status.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the number of non-empty switch cases from 46 to at most 30. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06MwHPLQrmbX5-9NFx&open=AZ06MwHPLQrmbX5-9NFx&pullRequest=1503

Check warning on line 59 in org.restlet/src/main/java/org/restlet/engine/Engine.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this hard-coded path-delimiter. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06MwDzLQrmbX5-9NFL&open=AZ06MwDzLQrmbX5-9NFL&pullRequest=1503

Check warning on line 139 in org.restlet/src/main/java/org/restlet/engine/util/EngineClassLoader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the synchronized class "Vector" by an unsynchronized one such as "ArrayList" or "LinkedList". 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ1VNbDa1_32ZbbIjGkJ&open=AZ1VNbDa1_32ZbbIjGkJ&pullRequest=1503

Check warning on line 908 in org.restlet/src/main/java/org/restlet/Request.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06MwNuLQrmbX5-9NG7&open=AZ06MwNuLQrmbX5-9NG7&pullRequest=1503

Check failure on line 969 in org.restlet/src/main/java/org/restlet/resource/ClientResource.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 25 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06MwKJLQrmbX5-9NGM&open=AZ06MwKJLQrmbX5-9NGM&pullRequest=1503

Check failure on line 154 in org.restlet.ext.crypto/src/main/java/org/restlet/ext/crypto/internal/HttpDigestHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06Mv0rLQrmbX5-9NC-&open=AZ06Mv0rLQrmbX5-9NC-&pullRequest=1503

Check warning on line 848 in org.restlet/src/main/java/org/restlet/data/Status.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the number of non-empty switch cases from 52 to at most 30. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06MwHPLQrmbX5-9NFw&open=AZ06MwHPLQrmbX5-9NFw&pullRequest=1503

Check warning on line 542 in org.restlet/src/main/java/org/restlet/data/MediaType.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This branch's code block is the same as the block for the branch on line 537. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ1Xta55mm9_Jq1qC5WW&open=AZ1Xta55mm9_Jq1qC5WW&pullRequest=1503

Check warning on line 174 in org.restlet/src/main/java/org/restlet/data/ClientInfo.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Return an empty collection instead of null. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ1VNbNA1_32ZbbIjGkK&open=AZ1VNbNA1_32ZbbIjGkK&pullRequest=1503

Check failure on line 648 in org.restlet/src/main/java/org/restlet/engine/local/DirectoryServerResource.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ1er904rHfHDGLiFlJh&open=AZ1er904rHfHDGLiFlJh&pullRequest=1503

Check warning on line 184 in org.restlet/src/main/java/org/restlet/engine/ssl/SslUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ1aa4E3Ubbqgtr7j832&open=AZ1aa4E3Ubbqgtr7j832&pullRequest=1503

Check warning on line 934 in org.restlet/src/main/java/org/restlet/data/MediaType.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=restlet_restlet-framework-java&issues=AZ06MwGSLQrmbX5-9NFp&open=AZ06MwGSLQrmbX5-9NFp&pullRequest=1503
View more details on SonarQubeCloud