fix(msdp): send room MSDP data on reconnect, not just fresh login - #277
Open
ahumbert wants to merge 1 commit into
Open
fix(msdp): send room MSDP data on reconnect, not just fresh login#277ahumbert wants to merge 1 commit into
ahumbert wants to merge 1 commit into
Conversation
Two of the four code paths that bring a descriptor into CON_PLYNG skip ProtocolNegotiate()/msdp_room_update() -- the "reconnect to an unswitched character" branch and a redundant quick-reconnect branch in nanny()'s CON_SLCT handler. ROOM and ROOM_EXITS are only ever populated by that one-shot call (unlike other MSDP stats, which self-heal via the periodic per-pulse diff-based refresh), so reconnecting clients were left with stale/missing room data until their next move. Live-verified via a scripted MSDP-negotiating telnet client: switched into a mob, hard-disconnected, reconnected -- confirmed ROOM, ROOM_EXITS, and CHARACTER_NAME were missing pre-fix and present post-fix, matching a fresh login.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the four code paths that bring a descriptor into CON_PLYNG skip ProtocolNegotiate()/msdp_room_update() -- the "reconnect to an unswitched character" branch and a redundant quick-reconnect branch in nanny()'s CON_SLCT handler. ROOM and ROOM_EXITS are only ever populated by that one-shot call (unlike other MSDP stats, which self-heal via the periodic per-pulse diff-based refresh), so reconnecting clients were left with stale/missing room data until their next move.
Live-verified via a scripted MSDP-negotiating telnet client: switched into a mob, hard-disconnected, reconnected -- confirmed ROOM, ROOM_EXITS, and CHARACTER_NAME were missing pre-fix and present post-fix, matching a fresh login.