Revamping ARO MIWI docs#956
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
kmcolli
left a comment
There was a problem hiding this comment.
great job really improving the article, a couple comments and suggestions
| #!/usr/bin/env bash | ||
| set -euo pipefail |
There was a problem hiding this comment.
do we need this? we are just doing a copy and paste
There was a problem hiding this comment.
thanks yeah that makes sense, will remove the shebang etc
| ```bash | ||
| az login | ||
| az account list --output table | ||
| az account set --subscription "<subscription-name-or-id>" |
There was a problem hiding this comment.
Separate it out as you can't copy and paste you nee the result from 58 to do what is on line 59
The subscription of '' doesn't exist in cloud 'AzureCloud'.
There was a problem hiding this comment.
good catch, let me split them into two steps, and maybe will add some verification command afterwards just to make sure
| echo "Pull secret not found: $AZR_PULL_SECRET" | ||
| exit 1 | ||
| } | ||
| ``` |
There was a problem hiding this comment.
echo out all variables in a new section?
There was a problem hiding this comment.
makes sense, will add it
| az provider register -n Microsoft.Authorization --wait | ||
| az provider register -n Microsoft.ContainerRegistry --wait | ||
| ``` | ||
| ## 3. Create the resource group and network |
There was a problem hiding this comment.
this assumes the vnet is in the same resource group as the cluster is in which many customers aren't doing ... separate out the vnet resource group to it's own as an environment variable
There was a problem hiding this comment.
right yeah will do this too
| ``` | ||
|
|
||
| az role assignment create --assignee-object-id "$(az identity show --resource-group ${RESOURCE_GROUP} --name ${ARO_CLUSTER_NAME}-ingress --query principalId -o tsv)" --assignee-principal-type ServicePrincipal --role "/subscriptions/${SUBSCRIPTION_ID}/providers/Microsoft.Authorization/roleDefinitions/0336e1d3-7a87-462b-b6db-342b63f7802c" --scope "/subscriptions/${SUBSCRIPTION_ID}/resourceGroups/${VNET_RESOURCE_GROUP}/providers/Microsoft.Network/virtualNetworks/${VNET_NAME}/subnets/${VNET_APP_NODE_SUBNET_NAME}" | ||
| Check DSv5-family usage: |
There was a problem hiding this comment.
describe more what to expect, the output won't be clear to some customers e.g.
[
{
"Restrictions": [],
"Size": "Standard_D4s_v5"
},
{
"Restrictions": [],
"Size": "Standard_D8s_v5"
}
]
There was a problem hiding this comment.
makes sense, will add some notes underneath to explain
| --vnet "$AZR_VNET" \ | ||
| --master-subnet "$AZR_MASTER_SUBNET" \ | ||
| --worker-subnet "$AZR_WORKER_SUBNET" \ | ||
| --master-vm-size "Standard_D8s_v5" \ |
There was a problem hiding this comment.
hard coded vm-sizes ... set as environment variables upfront with notes on how to change
There was a problem hiding this comment.
yeah good catch, i got impatient last minute and hardcoded this in my test lol
There was a problem hiding this comment.
please put it back, a few customer are using it ... update it with your new suggestions ( if you like :) )
There was a problem hiding this comment.
sure will put it back:) with some updates to match the non-automated version one
| ## One-Shot Deployment | ||
| ### 6.1 Allow the cluster identity to manage federated credentials | ||
|
|
||
| Download and execute the automated deployment script: |
There was a problem hiding this comment.
please put instructions back for running the 'automation' script as a few customers are using this
| {{% /alert %}} | ||
|
|
||
| ## Access the Cluster | ||
| To submit the operation and monitor it separately, add `--no-wait`. |
There was a problem hiding this comment.
just include this with the command because if you don't then you can do step 12
Also, add a note about the --debug ... or maybe that goes in troubleshooting
There was a problem hiding this comment.
ya makes sense will add --no-wait to the create command
|
|
||
| This guide assumes none is attached to the ARO subnets. When bringing those resources, add the operator role assignments required for each additional network resource before cluster creation. | ||
|
|
||
| ## Cleanup |
There was a problem hiding this comment.
there is also the vnet, subnets etc
There was a problem hiding this comment.
right yeah i'll rephrase this for clarity
Signed-off-by: dsari-rh <dsari@redhat.com>
Signed-off-by: dsari-rh <dsari@redhat.com>
Summary
This PR revamps the ARO Managed Identities and Workload Identity Federation guide to align with the current Azure CLI deployment workflow.
Key updates include:
The updated procedure was validated with a successful ARO managed-identity deployment.