Skip to content

fix(quilatom): format complex params with nonzero real and unit imaginary part #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devteamaegis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(quilatom): format complex params with nonzero real and unit imaginary part #1850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions pyquil/quilatom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,13 +419,15 @@ def format_parameter(element: ParameterDesignator) -> str:
out += repr(r)

if i == 1:
if not np.isclose(r, 0, atol=1e-14):
raise ValueError(f"Invalid complex number: {element}")
out = "i"
if np.isclose(r, 0, atol=1e-14):
out = "i"
else:
out += "+i"
elif i == -1:
if not np.isclose(r, 0, atol=1e-14):
raise ValueError(f"Invalid complex number: {element}")
out = "-i"
if np.isclose(r, 0, atol=1e-14):
out = "-i"
else:
out += "-i"
elif i < 0:
out += repr(i) + "i"
elif r != 0:
Expand Down
3 changes: 3 additions & 0 deletions test/unit/test_parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ def test_format_parameter():
(-1j, "-i"),
(1e-15 + 1j, "i"),
(1e-15 - 1j, "-i"),
(2 + 1j, "2.0+i"),
(2 - 1j, "2.0-i"),
(-3 + 1j, "-3.0+i"),
]

for test_case in test_cases:
Expand Down