Fix arrow keys not selecting blink.cmp completion candidates#203
Merged
Conversation
Add Up/Down arrow key mappings to blink.cmp keymap so completion candidates can be navigated with arrow keys instead of moving the cursor. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Code ReviewOverviewThis PR adds Code Quality & Style ✅The change is minimal and clean, and the implementation exactly follows the existing keymap pattern established by the ["<Up>"] = { "select_prev", "fallback" },
["<Down>"] = { "select_next", "fallback" },No issues here. Correctness ✅
Potential Concerns
Test CoverageThe test plan in the PR description covers the key scenarios:
These manual checks are appropriate for a Neovim config change — no automated test infrastructure exists or is needed here. SummaryApprove. This is a focused, correct, and idiomatic fix. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<Up>/<Down>arrow key mappings to blink.cmp keymap withselect_prev/select_nextactionsTest plan
🤖 Generated with Claude Code