Skip to content

Fix mason-lspconfig server name oxc → oxlint#205

Merged
rikuson merged 1 commit into
masterfrom
fix/oxlint-lsp-server-name
May 10, 2026
Merged

Fix mason-lspconfig server name oxc → oxlint#205
rikuson merged 1 commit into
masterfrom
fix/oxlint-lsp-server-name

Conversation

@rikuson

@rikuson rikuson commented May 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • Rename oxc to oxlint in mason-lspconfig ensure_installed so the correct nvim-lspconfig server is installed
  • Refresh lazy-lock.json with latest plugin commits

Test plan

  • Open Neovim and verify :Mason shows oxlint installed (not oxc)
  • Verify :LspInfo attaches oxlint to a JS/TS buffer
  • Confirm no startup errors from mason-lspconfig

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@rikuson rikuson enabled auto-merge (squash) May 10, 2026 08:55
@claude

claude Bot commented May 10, 2026

Copy link
Copy Markdown

Code Review: PR 205 - Fix mason-lspconfig server name oxc to oxlint

OVERVIEW: This PR makes two changes: (1) fixes the mason-lspconfig server name from oxc to oxlint in ensure_installed, and (2) bumps ~15 Neovim plugin commits in lazy-lock.json.

THE CORE FIX (nvim-lspconfig.lua): The rename is correct. oxc was never a valid mason-lspconfig server name - the correct identifier is oxlint. Without this fix, mason-lspconfig silently skips the entry or throws an error, so no linter attaches to JS/TS buffers. One thing to verify: the diff only shows the ensure_installed list. If the handlers table has a custom handler keyed on 'oxc', that would also need renaming. Based on the diff context (Default handler comment), a single catch-all handler appears to be in use - but worth confirming there is no per-server 'oxc' key elsewhere in the full file.

LOCK FILE UPDATE (lazy-lock.json): Concern - bundled upgrade scope. This commit updates ~15 unrelated plugins (gitsigns, lazy.nvim, lualine, mason, telescope, etc.) alongside a targeted bug fix. If a plugin upgrade later causes a regression, bisecting becomes harder. Consider splitting into two PRs in the future: one for the oxc fix and a separate chore PR for lock file bumps. That said, this is low priority for a personal dev environment repo. On the positive side, all commits are pinned by SHA rather than floating on branch tips, which is the correct Lazy.nvim pattern.

TEST PLAN: The checklist in the PR description covers the right scenarios - :Mason shows oxlint, :LspInfo attaches to JS/TS buffers, and no startup errors. No automated tests exist for Neovim config in this repo (expected), so manual verification is appropriate.

SUMMARY: The fix is correct and minimal. Two minor suggestions: (1) double-check there is no handlers['oxc'] key anywhere in nvim-lspconfig.lua that also needs renaming; (2) consider separating lock file bumps from bug fixes in future PRs to ease bisection. Otherwise this looks good to merge.

@rikuson rikuson merged commit 785b959 into master May 10, 2026
3 checks passed
@rikuson rikuson deleted the fix/oxlint-lsp-server-name branch May 10, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant