fix(search): enforce tenant isolation in SearchService#892
Open
godwinishaku506-hub wants to merge 1 commit into
Open
fix(search): enforce tenant isolation in SearchService#892godwinishaku506-hub wants to merge 1 commit into
godwinishaku506-hub wants to merge 1 commit into
Conversation
- Add tenantId column (nullable, indexed) to Course entity - Import TenancyModule into SearchModule so IsolationService is available - Inject IsolationService into SearchService - Add buildTenantFilter(tenantId) helper returning an ES term query - Apply tenantId filter as first WHERE clause in search() and getAutoComplete() - Add 7 tenant isolation tests covering cross-boundary isolation for both search() and getAutoComplete(), plus a no-query-params case Closes rinafcode#889
|
@godwinishaku506-hub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Great job so far There’s just one blocker — the workflow is failing. Could you take a look and fix it so all checks pass? Happy to review again once that’s done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #889 — search queries in
SearchServicereturned results across tenant boundaries.Changes
src/courses/entities/course.entity.tstenantIdcolumn (nullable, indexed)src/search/search.module.tsTenancyModule+TypeOrmModule.forFeature([Course])src/search/search.service.tsIsolationService; addbuildTenantFilter(); apply filter insearch()andgetAutoComplete()src/search/search.service.spec.tssearch(),getAutoComplete(), andbuildTenantFilter()Acceptance criteria
Testing