feat: Add PR syntax gate workflow that fails fast on TypeScript and lint errors#707
Merged
Conversation
|
@jotel-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
@RUKAYAT-CODER kindly review and merge |
…that-fails-fast-on-typescript-and-lint-errors
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have successfully addressed the task. Here is a summary of the work:
Created Git Branch: Switched to a new branch named 666-enhancement-add-pr-syntax-gate-workflow-that-fails-fast-on-typescript-and-lint-errors (sanitized for Git branch name compatibility).
Created Workflow File: Added
.github/workflows/syntax.yml
which executes tsc --noEmit and eslint . --max-warnings=0 on pull_request opened/synchronize events. It uses actions/cache@v4 for node modules and cancels in-progress jobs.
Updated Gitignore: Modified
.gitignore
to add !CONTRIBUTING.md as an exception to the root markdown file ignoring pattern.
Created Documentation: Added
CONTRIBUTING.md
to document the syntax gate and provide developers with local validation commands.
Committed & Pushed: Staged, committed, and pushed the new branch to origin.
closes #666