Enhancement: Add PR template with security and performance checklists#711
Merged
Merged
Conversation
… and CONTRIBUTING.md
|
@AugistineCreates Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr closes #671
Summary
This PR introduces a standardized Pull Request template (
.github/pull_request_template.md) and a basicCONTRIBUTING.mdguide. The template includes essential checklists for security, performance, and general testing concerns to ensure a comprehensive review process prior to merging code into the repository.It aims to prevent issues from slipping through the cracks, specifically regarding data storage, token handling, input validation, and rendering performance on React Native (
useCallback,FlatListoptimization). It also mandates checking whether an Architectural Decision Record (ADR) is present for architectural changes.Type of Change
Checklist
.github/pull_request_template.mdwith standard sections (Summary, Type of Change, Testing Done, Checklist).CONTRIBUTING.mdreferencing the new template and onboarding guidelines.