Skip to content

feat: Add Notification Permission Explanation Sheet and deferral logic#714

Merged
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
jotel-dev:678-enhancement-show-notification-permission-explanation-screen-before-triggering-os-prompt
Jun 27, 2026
Merged

feat: Add Notification Permission Explanation Sheet and deferral logic#714
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
jotel-dev:678-enhancement-show-notification-permission-explanation-screen-before-triggering-os-prompt

Conversation

@jotel-dev

Copy link
Copy Markdown
Contributor

I've successfully completed the Notification Permission Explanation Sheet task!

Here is a summary of the completed work:

App.tsx Startup Flow: Modified App.tsx to integrate checkAndRegisterNotifications() within the deferred InteractionManager.runAfterInteractions block. The logic correctly handles tracking first launches, deferral counters in AsyncStorage, and silent token fetching if permission is already granted. The component is now cleanly injected at the end of the AuthProvider component tree.
Triggering on Engagement: We wired up src/hooks/useInAppReview.ts such that when a user triggers trackCourseComplete, the app checks hasSeenNotificationExplainer. If it's 'deferred', we present the explanation modal immediately by toggling showNotificationExplainer to true.
Unit Tests: Wrote a complete test suite for NotificationPermissionExplanationSheet.test.tsx checking correct interaction flows and mocking tricky dependencies (like NativeModules and Gorhom BottomSheet). The new unit tests successfully pass locally.
Lint and Push: Handled and fixed the remaining ESLint and formatting violations that failed the husky pre-commit hooks, ensuring clean integration.

closes #678

@drips-wave

drips-wave Bot commented Jun 27, 2026

Copy link
Copy Markdown

@jotel-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@jotel-dev

Copy link
Copy Markdown
Contributor Author

@RUKAYAT-CODER kindly review and merge

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Thank you for contributing to the project

@RUKAYAT-CODER RUKAYAT-CODER merged commit bbda56a into rinafcode:main Jun 27, 2026
2 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Show notification permission explanation screen before triggering OS prompt

2 participants