fix(auth): prevent raw OAuth JSON errors from showing in MobileLogin#720
Merged
RUKAYAT-CODER merged 1 commit intoJun 28, 2026
Merged
Conversation
|
@temisan0x Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
temisan0x
force-pushed
the
fix/676-oauth-error-display
branch
3 times, most recently
from
4e48457 to
e9f8d12
Compare
Closes rinafcode#676 - Add src/utils/authErrorMessages.ts mapping OAuth error codes (invalid_grant, access_denied, etc.) to user-friendly messages - useAuth.tsx login() catch block now logs the raw Axios error via appLogger.error for debugging, then throws a sanitized Error with a mapped message instead of re-throwing the raw response - Unknown/undefined error codes fall back to a generic message - Add unit tests covering invalid_grant, access_denied, and unknown code paths
temisan0x
force-pushed
the
fix/676-oauth-error-display
branch
from
468890a to
9e413de
Compare
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #676
What changed
src/utils/authErrorMessages.ts— maps OAuth error codes likeinvalid_grantandaccess_deniedto plain English messages, with a generic fallback for anything unexpected.useAuth.tsxandMobileLogin.tsxnow show those friendly messages in the UI instead of raw JSON.appLogger.errorso debugging isn't affected.MobileLogin.tsxwhile I was in there — the react-hook-form setup was broken and not actually doing anything, replaced it with simple local state.Testing
Notes
MobileLoginwas handling errors separately. Fixing both is what actually gets this in front of users.