feat: implement Twitter Cards metadata across all app pages#698
Open
KingDavid9999 wants to merge 6 commits into
Open
feat: implement Twitter Cards metadata across all app pages#698KingDavid9999 wants to merge 6 commits into
KingDavid9999 wants to merge 6 commits into
Conversation
- Add twitter and openGraph fields to root layout metadata (global default) - Create (auth)/layout.tsx with Twitter Cards for login, signup, verify-email - Extend metadata in editor, search, study-groups, leaderboard, privacy pages - Add Twitter Cards to generateMetadata in topics/[slug] and courses/[courseId] - Add unit tests to verify twitter card fields across layout files Closes rinafcode#378
|
@KingDavid9999 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Great job so far There’s just one blocker — the workflow is failing. Could you take a look and fix it so all checks pass? Happy to review again once that’s done. |
Author
|
Hi @RUKAYAT-CODER Conflicts resolved and line endings normalized. CI workflows are awaiting your approval to run. Ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Twitter Cards metadata across the TeachLink application to improve social sharing previews and overall SEO quality.
Changes
src/app/layout.tsx): addedtwitterandopenGraphto the global metadata export, serving as the default fallback for all pagessrc/app/(auth)/layout.tsx): created new server-side layout wrapper with Twitter Cards for login, signup, and verify-email pages (which are'use client'and cannot export metadata directly)editor,search,study-groups,leaderboard, andprivacypages withtwitterandopenGraphfieldsgenerateMetadataintopics/[slug]andcourses/[courseId]to include Twitter Cards using computed valuessrc/app/__tests__/twitter-cards.test.ts): added unit tests asserting correct card types, titles, descriptions, and site handles across root, auth, dashboard, and profile layoutsType of Change
Testing
Checklist
import type { Metadata } from 'next', same object shape and formatting)Closes #378