Skip to content

Translation parameter replacement regex does not support nested keys …#789

Merged
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
innovativedesign-lab:transalation-parameter
Jun 27, 2026
Merged

Translation parameter replacement regex does not support nested keys …#789
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
innovativedesign-lab:transalation-parameter

Conversation

@innovativedesign-lab

@innovativedesign-lab innovativedesign-lab commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Close: #776

Description

All three files are clean. Here's a summary of everything done:

Changes made

translationManager.ts

Regex updated from /{{(\w+)}}/g → /{{([\w][\w.]*)}}/g — now matches dot-separated paths like {{user.name}}
Param resolution replaced with paramPath.split('.').reduce(...) to traverse nested objects
Added console.warn with the full key path when a placeholder resolves to undefined/null, leaving the original placeholder visible in output
params type widened from Record<string, string | number> to Record<string, unknown> to accept nested objects
useInternationalization.tsx

Both t callback and fallbackT had their params type widened to match — no breaking change for existing flat-key callers since string | number is a subtype of unknown
translationManager.test.ts
(new)

13 tests across 6 describe blocks covering: flat replacement (regression), two-level nested, three-level nested, missing key warning, no-params passthrough, multiple placeholders, and unknown key passthrough
Run tests with:

pnpm test -- src/locales/translationManager.te

Related Issue

Close: #

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • No console errors
  • Uses Lucide icons consistently
  • Responsive design implemented
  • Starknet best practices followed

@drips-wave

drips-wave Bot commented Jun 27, 2026

Copy link
Copy Markdown

@innovativedesign-lab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@innovativedesign-lab

Copy link
Copy Markdown
Contributor Author

Done, Close: #789

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Thank you for contributing to the project.

@RUKAYAT-CODER RUKAYAT-CODER merged commit 879313c into rinafcode:main Jun 27, 2026
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor] Translation parameter replacement regex does not support nested keys or escaped braces

2 participants