Translation parameter replacement regex does not support nested keys …#789
Merged
RUKAYAT-CODER merged 1 commit intoJun 27, 2026
Merged
Conversation
…or escaped braces
|
@innovativedesign-lab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Done, Close: #789 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #776
Description
All three files are clean. Here's a summary of everything done:
Changes made
translationManager.ts
Regex updated from /{{(\w+)}}/g → /{{([\w][\w.]*)}}/g — now matches dot-separated paths like {{user.name}}
Param resolution replaced with paramPath.split('.').reduce(...) to traverse nested objects
Added console.warn with the full key path when a placeholder resolves to undefined/null, leaving the original placeholder visible in output
params type widened from Record<string, string | number> to Record<string, unknown> to accept nested objects
useInternationalization.tsx
Both t callback and fallbackT had their params type widened to match — no breaking change for existing flat-key callers since string | number is a subtype of unknown
translationManager.test.ts
(new)
13 tests across 6 describe blocks covering: flat replacement (regression), two-level nested, three-level nested, missing key warning, no-params passthrough, multiple placeholders, and unknown key passthrough
Run tests with:
pnpm test -- src/locales/translationManager.te
Related Issue
Close: #
Type of Change
Checklist