feat(security): implement input validation for notification endpoints#799
Open
dot-enny wants to merge 4 commits into
Open
feat(security): implement input validation for notification endpoints#799dot-enny wants to merge 4 commits into
dot-enny wants to merge 4 commits into
Conversation
|
@dot-enny Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces robust input validation using Zod for the notification system endpoints to resolve security issue #363.
Key changes include:
src/schemas/notification.schema.tsto enforce safe bounds on properties (e.g. constraints on string lengths and type enums)./api/notifications/send-notification,/api/notifications/track, and/api/notifications/subscribe.src/lib/notifications/__tests__/api-validation.test.tsto ensure invalid payloads correctly return400 Bad Requestand valid payloads parse properly.Related Issue
Closes #363
Type of Change
Checklist