chore(cache): remove unused session-cache invalidation methods#382
Merged
Conversation
invalidateAll / invalidateSession / invalidateSessionsList had zero callers anywhere in the codebase — the session cache is TTL-only (15s–10min expiries), so these were vestigial scaffolding. Removing them also drops a blocking Redis KEYS scan that lived in the never-called invalidateAll. No behaviour change (the methods were dead); no specs referenced them. Build + lint + full suite (987 tests) green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CacheService.invalidateAll,invalidateSession, andinvalidateSessionsListhave zero callers anywhere in the codebase (verified by repo-wide grep; no spec references them either). The session cache is TTL-only — entries expire on their own (15s–10min), and nothing ever invoked proactive invalidation — so these three methods were vestigial scaffolding.Removing them also drops a blocking
redis.keys('session:*')scan that lived inside the never-calledinvalidateAll(a latent footgun had it ever been wired up).Notes
invalidateSessioninto the session lifecycle) — intentionally out of scope here.