-
-
Notifications
You must be signed in to change notification settings - Fork 18
feature-notification: animated Edit Schema with AI popup #1782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
karinakharchenko
wants to merge
6
commits into
rocket-admin:main
Choose a base branch
from
karinakharchenko:updates-popup-edit-schema
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3d0b6bd
feat(feature-notification): SVG animation for Edit Schema with AI
karinakharchenko 65c59a7
feat(feature-notification): merge schema-build and find-it-here into …
karinakharchenko db842ef
chore(feature-notification): show Edit schema as text button in card
karinakharchenko cd974fc
feat(feature-notification): three-act animation telling the AI schema…
karinakharchenko 8cc5361
chore(feature-notification): bigger typed prompt + clearer description
karinakharchenko 2b0fe09
chore(feature-notification): full-width popup on mobile
karinakharchenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reduced-motion shows Act 2 input field overlapping Act 3 content.
With
prefers-reduced-motion: reduce,.fn-inputis set toopacity: 1(line 325), but the input field's y-position (136–166) overlaps with the "Schema ready" text (y=162). Since the final frame should show the completed schema state, the input field from the typing phase should be hidden.🛠️ Proposed fix
Either remove
.fn-inputfrom the visible list and add it to the hidden elements, or hide the entire Act 2 group:`@media` (prefers-reduced-motion: reduce) { .fn-placeholder, .fn-add-button, .fn-pointer-1, .fn-click-ripple, .fn-chat-title--final, .fn-chat-divider, - .fn-input, - .fn-caret, - .fn-send-button, - .fn-user-message, .fn-ai-avatar, .fn-table, .fn-link, .fn-schema-ready { animation: none !important; opacity: 1 !important; transform: none !important; stroke-dashoffset: 0 !important; } + .fn-input, + .fn-caret, + .fn-send-button { + display: none !important; + } .fn-typing-clip { animation: none !important; width: 180px !important; } .fn-chat-title--initial { display: none !important; } .fn-act--1 { display: none !important; } }🤖 Prompt for AI Agents