Wait for validator index to be included in finalized state before calling GetValidatorProof in stake-megapool-validator.go

[thomaspanf]

stake-megapool-validator.go uses the head state of the beacon chain to check if a prestaking megapool validator should be staked. If the beacon index of a prestaking validator exists in the head state but not in the finalized state, GetValidatorProof will fail.

The node loop repeats this until the validator's beacon index exists in the finalized state, then the call succeeds and the validator is successfully staked.

This PR resolves the issue by checking if the validator's beacon index exists in the finalized state before calling GetValidatorProof.

2026/03/30 00:55:48 Checking for megapool validators to stake...
2026/03/30 00:56:06 The validator id 10 needs to be staked
2026/03/30 00:56:06 Crafting a proof that the correct credentials were used on the first beacon chain deposit. This process can take several seconds and is CPU and memory intensive.
2026/03/30 00:56:16 There was an error during the proof creation process: %!w(*errors.errorString=&{validator index out of bounds})
2026/03/30 00:56:16 Error staking validator 10: %!w(*errors.errorString=&{validator index out of bounds})
2026/03/30 00:56:17 Checking if there are megapool validators exiting...
2026/03/30 00:56:18 Checking if there are megapool validators with a final balance withdrawn...
2026/03/30 00:56:19 Checking for express tickets to provision...
2026/03/30 00:56:20 Checking for minipools to distribute...
2026/03/30 00:56:21 Checking for minipools to set use latest delegate...
2026/03/30 01:01:56 Getting network state for EL block 2516950, Beacon slot 2720350
2026/03/30 01:02:02 1/9 - Retrieved network details (5.811955741s so far)
2026/03/30 01:02:03 2/9 - Retrieved node details (7.442769371s so far)
2026/03/30 01:02:04 3/9 - Retrieved minipool details (8.131677859s so far)
2026/03/30 01:02:07 4/9 - Retrieved megapool validator global index (10.73950999s so far)
2026/03/30 01:02:52 5/9 - Retrieved megapool validator details (56.378137199s so far)
2026/03/30 01:02:53 6/9 - Retrieved Oracle DAO details (57.085745685s so far)
2026/03/30 01:02:53 7/9 - Retrieved validator details (57.085840097s so far)
2026/03/30 01:02:53 8/9 - Calculated complete node and user balance shares (57.085866779s so far)
2026/03/30 01:02:54 9/9 - Retrieved Protocol DAO proposals (total time: 57.963132309s)
2026/03/30 01:02:54 Checking for correct fee recipient...
2026/03/30 01:02:54 Successfully checked for the correct fee recipient, you are now validating safely.
2026/03/30 01:02:55 Checking for validators with an incorrect exit challenge ...
2026/03/30 01:03:00 Checking for new rewards tree files to download...
2026/03/30 01:03:01 Checking for Protocol DAO proposal challenges to defend...
2026/03/30 01:03:02 Checking for Protocol DAO proposals to challenge...
2026/03/30 01:03:03 Checking for megapool validators to pre-stake...
2026/03/30 01:03:04 Checking for megapool validators to stake...
2026/03/30 01:03:21 The validator id 10 needs to be staked
2026/03/30 01:03:21 Crafting a proof that the correct credentials were used on the first beacon chain deposit. This process can take several seconds and is CPU and memory intensive.
2026/03/30 01:03:31 There was an error during the proof creation process: %!w(*errors.errorString=&{validator index out of bounds})
2026/03/30 01:03:31 Error staking validator 10: %!w(*errors.errorString=&{validator index out of bounds})
2026/03/30 01:03:32 Checking if there are megapool validators exiting...
2026/03/30 01:03:33 Checking if there are megapool validators with a final balance withdrawn...
2026/03/30 01:03:34 Checking for express tickets to provision...
2026/03/30 01:03:35 Checking for minipools to distribute...
2026/03/30 01:03:36 Checking for minipools to set use latest delegate...
2026/03/30 01:08:41 Getting network state for EL block 2516988, Beacon slot 2720393
2026/03/30 01:08:42 1/9 - Retrieved network details (1.440761978s so far)
2026/03/30 01:08:43 2/9 - Retrieved node details (2.141154541s so far)
2026/03/30 01:08:43 3/9 - Retrieved minipool details (2.488323508s so far)
2026/03/30 01:08:45 4/9 - Retrieved megapool validator global index (4.083406037s so far)
2026/03/30 01:08:47 5/9 - Retrieved megapool validator details (5.724097827s so far)
2026/03/30 01:08:47 6/9 - Retrieved Oracle DAO details (6.41208376s so far)
2026/03/30 01:08:47 7/9 - Retrieved validator details (6.412216955s so far)
2026/03/30 01:08:47 8/9 - Calculated complete node and user balance shares (6.412240699s so far)
2026/03/30 01:08:48 9/9 - Retrieved Protocol DAO proposals (total time: 7.273374518s)
2026/03/30 01:08:49 Checking for correct fee recipient...
2026/03/30 01:08:49 Successfully checked for the correct fee recipient, you are now validating safely.
2026/03/30 01:08:50 Checking for validators with an incorrect exit challenge ...
2026/03/30 01:08:52 Checking for new rewards tree files to download...
2026/03/30 01:08:53 Checking for Protocol DAO proposal challenges to defend...
2026/03/30 01:08:54 Checking for Protocol DAO proposals to challenge...
2026/03/30 01:08:55 Checking for megapool validators to pre-stake...
2026/03/30 01:08:57 Checking for megapool validators to stake...
2026/03/30 01:09:27 The validator id 10 needs to be staked
2026/03/30 01:09:27 Crafting a proof that the correct credentials were used on the first beacon chain deposit. This process can take several seconds and is CPU and memory intensive.
2026/03/30 01:09:47 The beacon state proof has been successfully created.
2026/03/30 01:09:47 This transaction will use a max fee of 0.000000 Gwei, for a total of up to 0.000000 - 0.000000 ETH.
2026/03/30 01:09:48 Transaction has been submitted with hash 0xff4f39c6348375025c714d74a7f1ad034340f9bfdb4d87e40348c318fd19f6bf.
2026/03/30 01:09:48 You may follow its progress by visiting:
2026/03/30 01:09:48 https://hoodi.etherscan.io/tx/0xff4f39c6348375025c714d74a7f1ad034340f9bfdb4d87e40348c318fd19f6bf
2026/03/30 01:09:26 Waiting for the transaction to be validated...
2026/03/30 01:09:50 Successfully staked validator 10.
2026/03/30 01:09:50 Restarting validator process with command '/home/staker/.rpnative/restart-vc.sh'...

[github-actions]

Coverage Report

[github-actions]

Merging this branch will not change overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/rocket-pool/smartnode/rocketpool/node	0.00% (ø)

---

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/rocket-pool/smartnode/rocketpool/node/stake-megapool-validator.go	0.00% (ø)	1241 (+100)	0	1241 (+100)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.