Allow choosing a token env var name, and include a deploy comment#10
Open
glenjamin wants to merge 2 commits into
Open
Allow choosing a token env var name, and include a deploy comment#10glenjamin wants to merge 2 commits into
glenjamin wants to merge 2 commits into
Conversation
|
Hi @igayoso, Samuel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making the token a parameter allows for using multiple tokens in a single job more easily.
As documented here: https://circleci.com/docs/2.0/reusing-config/#environment-variable-name
I've also included the short version of the git commit as the deploy comment
I haven't tested these changes yet - they're based on our own non-orb usage of rollbar, I wanted to post the PR for feedback. I'll look at running this as a dev orb and confirm back here when I know things are fully working.