feat: Add OIDC SSO#84
Open
serendipty01 wants to merge 9 commits into
Open
Conversation
serendipty01
force-pushed
the
add-oidc-sso
branch
7 times, most recently
from
97bba63 to
515762c
Compare
serendipty01
force-pushed
the
add-oidc-sso
branch
2 times, most recently
from
298aa43 to
3cd5807
Compare
serendipty01
force-pushed
the
add-oidc-sso
branch
2 times, most recently
from
6bcf124 to
87e92bd
Compare
serendipty01
requested review from
a team,
cassidyjames,
dom-notion,
juanmrad,
julietshen,
pawiecz and
vinaysrao1
as code owners
juanmrad
requested changes
Apr 4, 2026
serendipty01
force-pushed
the
add-oidc-sso
branch
4 times, most recently
from
4da4829 to
daacab4
Compare
juanmrad
reviewed
Apr 14, 2026
Member
juanmrad
left a comment
juanmrad
left a comment
There was a problem hiding this comment.
a couple more comments. 😅 Thanks for all the hard work.
Member
|
@serendipty01 left you a couple more comments. let me know if you need help, and again thanks for contributing. |
serendipty01
force-pushed
the
add-oidc-sso
branch
4 times, most recently
from
7f3314d to
658ed70
Compare
serendipty01
force-pushed
the
add-oidc-sso
branch
from
658ed70 to
a0d56a8
Compare
serendipty01
commented
Apr 25, 2026
|
|
||
| permissions: | ||
| pull-requests: write | ||
| issues: write |
Contributor
Author
There was a problem hiding this comment.
this is for resolving the failing checklist job.
Should i remove this or raise a separate PR for this ?
serendipty01
commented
Apr 25, 2026
|
|
||
| export const DateStringArbitrary = fc | ||
| .date() | ||
| .date({ noInvalidDate: true }) |
Contributor
Author
There was a problem hiding this comment.
this change is for fixing a test failure
serendipty01
force-pushed
the
add-oidc-sso
branch
3 times, most recently
from
c65e0b8 to
c3950d2
Compare
juanmrad
approved these changes
Apr 29, 2026
Member
juanmrad
left a comment
juanmrad
left a comment
There was a problem hiding this comment.
@serendipty01 Just to doubly confirm you manually tested this change correct?
ThisIsMissEm
left a comment
ThisIsMissEm
left a comment
There was a problem hiding this comment.
Left some comments that may be worth addressing before merge.
serendipty01
force-pushed
the
add-oidc-sso
branch
from
c3950d2 to
902e794
Compare
serendipty01
force-pushed
the
add-oidc-sso
branch
from
902e794 to
54a5587
Compare
… from schema, use ConfigService for apiUrl
serendipty01
force-pushed
the
add-oidc-sso
branch
from
54a5587 to
9c52ed5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Requests for Reviewers
fixes #335
Currently, Coop only supports SAML for Single Sign-On (SSO). This PR adds OpenID Connect (OIDC) support to enable modern authentication flows and provide better compatibility with identity providers that support OIDC.
This PR is using openid-client library
TODO
client_secret_basicorclient_secret_postTests
Tested locally using Authelia
will add screenshots/video later
(Optional) Rollout Plan