Skip to content

[svg] fix missing math symbols#22318

Merged
linev merged 8 commits into
root-project:masterfrom
ferdymercury:patch-22
May 19, 2026
Merged

[svg] fix missing math symbols#22318
linev merged 8 commits into
root-project:masterfrom
ferdymercury:patch-22

Conversation

@ferdymercury
Copy link
Copy Markdown
Collaborator

from latex5 tutorial

as found out in #22317 (review)

from latex5 tutorial
@ferdymercury ferdymercury requested a review from linev May 18, 2026 08:14
@ferdymercury ferdymercury marked this pull request as ready for review May 18, 2026 10:35
@ferdymercury ferdymercury reopened this May 18, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

Test Results

    22 files      22 suites   3d 15h 40m 21s ⏱️
 3 855 tests  3 854 ✅ 0 💤 1 ❌
77 037 runs  77 036 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 82400c7.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Member

@linev linev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check small epsilon again.
After your changes it does not look ok.
One can nicely see it in tlatex4.svg changes

@linev linev assigned linev and unassigned ferdymercury May 19, 2026
@ferdymercury
Copy link
Copy Markdown
Collaborator Author

ferdymercury commented May 19, 2026

Please check small epsilon again.
After your changes it does not look ok.

you mean that the symbol is not centered? (the character is the correct one, matches the png)

Is it worth to fix the alignment? It depends on the width of the glyph...? not sure how to fix it, and it's independent of this PR ?

@linev
Copy link
Copy Markdown
Member

linev commented May 19, 2026

you mean that the symbol is not centered? (the character is the correct one, matches the png)

It is very strange. For me small epsilon character is:

https://www.compart.com/en/unicode/U+03B5

But ROOT renders it differently.
Seems to be it comes from TeX tradition.

Rest is fine for me.

Copy link
Copy Markdown
Member

@linev linev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it!

@linev linev merged commit 2b3a4be into root-project:master May 19, 2026
68 of 91 checks passed
@ferdymercury
Copy link
Copy Markdown
Collaborator Author

But ROOT renders it differently.
Seems to be it comes from TeX tradition.

yes, I agree with you it seems weird :)

osschar confirmed it was on purpose: #22076 (comment)

and here: https://tex.stackexchange.com/a/472233

@ferdymercury ferdymercury deleted the patch-22 branch May 19, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants