[cmake] mv glad to builtins

[ferdymercury]

For consistency with other hard-coded builtins such as afterimage and mathtext

[guitargeek]

Hi! FYI, glad is not a builtin dependency. It's code auto-generated by the tool with the same name.

Since the code generation was customized to bring exactly what ROOT needs, and the whole idea of glad is that you just copy-paste the generated code into your project, I wouldn't consider this code a "builtin dependency".

[ferdymercury]

I wouldn't consider this code a "builtin dependency".

In my opinion: yes and no.
Mathtext is a bit the same: copy-pasted and adapted to ROOT's needs.

Why do I advocate to put in the builtins folder ? Because it was generated externally. This way, if they fix something in the upstream version such as Dav1dde/glad@cef3f89
we can "update" the call to glad and overwrite gl.c files etc. We would only override things in the builtins.

If twice a year we say let's update all our builtins for upstream fixes, we won't forget about glad. If it's deep inside graf3d, we will for sure forget. Getting the overview in a single folder is relevant in my opinion.

[github-actions]

Test Results

    23 files      23 suites   3d 13h 14m 45s ⏱️
 3 873 tests  3 872 ✅ 0 💤 1 ❌
76 195 runs  76 194 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 252d01d.

♻️ This comment has been updated with latest results.

[dpiparo]

a last round of tests...