Add checksum to S3 Anchor and change clone template as file-constant#22819
Add checksum to S3 Anchor and change clone template as file-constant#22819JasMehta08 wants to merge 2 commits into
Conversation
1373142 to
5f539d7
Compare
5f539d7 to
bfe8630
Compare
bfe8630 to
5945e72
Compare
|
@silverweed and @jblomer I have removed the clone template from the anchor, and made it a file-constant, please have a new review of the commits |
| /// the stored JSON uses pretty-printing for readability. | ||
| std::string ROOT::Experimental::Internal::RNTupleAnchorS3::ToJSON() const | ||
| { | ||
| auto canonical = CanonicalPayload(*this); |
There was a problem hiding this comment.
Aren't we duplicating quite a bunch of work here? I get we need to serialize the anchor to compute the checksum and then add it to the JSON representation, but can't we add the checksum via string manipulation? (replacing canonical's last } with ,"checksum":...).
There was a problem hiding this comment.
Yes, we can remove the use of CanonicalPayload from ToJSoN(), if we can just use the jsonAnchor to create the checksum and add the field at the end. I will update it to do so.
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 5945e72. |
1d7e1db to
5b189a8
Compare
5b189a8 to
06b9980
Compare
|
I have updated the implementation, and removed |
This Pull request:
(Is a part of the GSoC 2026 project
S3 Backend for RNTuple.)Adds checksum and a configurable clone path to the S3 Anchor.
Changes or fixes:
CloneAsHiddenwith a file-local constant (kDefaultCloneTemplate).Checklist: