[cppyy] Fix std::string return-type tests to match Pythonizations#22827
Merged
Conversation
Un-xfail test18_operator_plus_overloads and test34_cstring_template_argument, which check that C++ functions returning a `std::string` produce a string on the Python side. These tests previously asserted the return type was exactly `cppyy.gbl.std.string`. That assumption is too strict: depending on which Pythonizations are enabled, a `std::string` returned from C++ may map to a different Python-side type. Compare instead against the type produced by a known `std::string`-returning function, `std::to_string(42)`, so the tests verify consistent behavior rather than one specific type.
siliataider
approved these changes
Jul 16, 2026
siliataider
left a comment
siliataider
left a comment
Contributor
There was a problem hiding this comment.
Makes sense, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Un-xfail test18_operator_plus_overloads and
test34_cstring_template_argument, which check that C++ functions returning a
std::stringproduce a string on the Python side.These tests previously asserted the return type was exactly
cppyy.gbl.std.string. That assumption is too strict: depending on which Pythonizations are enabled, astd::stringreturned from C++ may map to a different Python-side type. Compare instead against the type produced by a knownstd::string-returning function,std::to_string(42), so the tests verify consistent behavior rather than one specific type.