Split Graf3d and the Geant 3 TGeometry shapes#22845
Open
hageboeck wants to merge 12 commits into
Open
Conversation
hageboeck
force-pushed
the
splitOffTGeometry
branch
from
July 17, 2026 15:09
abe1097 to
932a89d
Compare
Test Results 23 files 23 suites 3d 18h 22m 19s ⏱️ Results for commit 932a89d. |
- Splot depended on graf3d, but it didn't use any of its classes. - Montecarlo was including graf3d headers. It is sufficient to include in the .cxx, though.
Markers and lines in Graf3D are coupled to TGeometry, but this coupling can be broken by not including TGeometry. This would only break one single feature, which is that markers and lines transform based on the currently active geometry. This remains supported by declaring a transform function in graf3d/g3d. This transform function can be accessed from TGeometry, eventually allowing for putting TGeometry and all its shapes into a dedicated library.
hageboeck
force-pushed
the
splitOffTGeometry
branch
from
July 20, 2026 12:31
932a89d to
156ccba
Compare
hageboeck
marked this pull request as ready for review
July 20, 2026 12:45
hageboeck
requested review from
bellenot,
couet,
dpiparo and
linev
as code owners
July 20, 2026 12:45
hageboeck
force-pushed
the
splitOffTGeometry
branch
from
July 20, 2026 13:36
8336b6f to
da07b04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in PPP200, it would make sense if the Geant 3 geometry shapes switch on/off at the same time as other geometries, that is, using
-Dgeom=On/Off.To achieve this, the shapes have been moved into their own library "TGeometry". Graf3d only retains classes such as TPolyMarker3D, TPolyLine3D and similar, since these are used in other parts of ROOT. The implementations of the shapes and the (pre-TGeo) geometry classes aren't used anywhere, so they can be in their own library.
The commits are ordered in a few steps:
#include <TGeometry.h>from TPolyMarker3D and similar.Note:
I clang-formatted as best as I could, but I did not format the commit that moved all the files. This would have created unnecessary noise.