[RF] Address the RooFormulaVar re-indexing issue during serialization#22850
Open
tekinertekin wants to merge 1 commit into
Open
[RF] Address the RooFormulaVar re-indexing issue during serialization#22850tekinertekin wants to merge 1 commit into
tekinertekin wants to merge 1 commit into
Conversation
RooFormulaVar @n indices were inconsistent after a write-read cycle in cases where some of the unused parameters have been trimmed, causing incorrect results. We now use the method RooFormula::reindexedFormulaForUsedVars(), which re-indexes the saved formula expression to the position of the usedVariables(), in the 4 spots where _formExpr is being set (both constructors, copy constructor and redirectServersHook). Fixes root-project#21371
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
RooFormulaVar @n indices were inconsistent after a write-read cycle in cases where some of the unused parameters have been trimmed, causing incorrect results. We now use the method RooFormula::reindexedFormulaForUsedVars(), which re-indexes the saved formula expression to the position of the usedVariables(), in the 4 spots where _formExpr is being set (both constructors, copy constructor and redirectServersHook). The code was authored by me. Claude Opus 4.8 assisted with reproducing the bug, local builds/tests, and reviewing the code — it did not generate any of the code. This is the binary/TFile equivalent of the same bug fixed in #17291; it came from there because that path wasn't tested — this PR closes that gap.
Added a regression test RooFormula.SerializationWithUnusedParam.
Fix For:
Fixes #21371
Checklist:
This PR fixes #21371