[ntuple] fix type check in REntry::BindRawPtr()#22857
Merged
Merged
Conversation
Test Results 22 files 22 suites 3d 10h 38m 18s ⏱️ Results for commit f341b33. ♻️ This comment has been updated with latest results. |
hahnjo
reviewed
Jul 20, 2026
hahnjo
left a comment
hahnjo
left a comment
Member
There was a problem hiding this comment.
Looks good - should we add a test?
hahnjo
approved these changes
Jul 20, 2026
jblomer
force-pushed
the
ntuple-fix-bindrawptr
branch
from
July 20, 2026 21:10
8d78411 to
f341b33
Compare
The BindRawPtr() overload receiving a field name mistakenly disabled the type check.
Contributor
Author
|
/backport to 6.40 |
|
Preparing to backport PR #22857 to branch 6.40 requested by jblomer |
|
This PR has been backported to branch 6.40: #22864 |
Contributor
Author
|
/backport to 6.36 |
|
Preparing to backport PR #22857 to branch 6.36 requested by jblomer |
|
This PR has been backported to branch 6.36: #22865 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BindRawPtr() overload receiving a field name mistakenly disabled the type check.
Requires backport to 6.40 and 6.36
Fixes #22856