Skip to content

[dictgen] Also forward declare namespaces, typedefs, enums:#8661

Open
Axel-Naumann wants to merge 1 commit into
root-project:masterfrom
Axel-Naumann:dict-fwd-decl-ns-td-enum
Open

[dictgen] Also forward declare namespaces, typedefs, enums:#8661
Axel-Naumann wants to merge 1 commit into
root-project:masterfrom
Axel-Naumann:dict-fwd-decl-ns-td-enum

Conversation

@Axel-Naumann

@Axel-Naumann Axel-Naumann commented Jul 13, 2021

Copy link
Copy Markdown
Member

They were picked up as side effects of classes, but not forward declared as
and by themselves. This fixes namespaces and enums not being available / known at the ROOT prompt despite their dictionary being loaded:
https://root-forum.cern.ch/t/enum-in-namespace-not-available-after-loading-dictionary/45757

@Axel-Naumann Axel-Naumann self-assigned this Jul 13, 2021
@phsft-bot

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@Axel-Naumann
Axel-Naumann force-pushed the dict-fwd-decl-ns-td-enum branch from e50d397 to 22a84ec Compare July 13, 2021 14:07
@phsft-bot

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot

Copy link
Copy Markdown

@phsft-bot

Copy link
Copy Markdown

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-07-13T15:46:23.191Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory

Failing tests:

@dpiparo

dpiparo commented Jun 24, 2024

Copy link
Copy Markdown
Member

Restarted all tests to see how we are performing...

@github-actions

github-actions Bot commented Jun 24, 2024

Copy link
Copy Markdown

Test Results

    21 files      21 suites   3d 15h 10m 32s ⏱️
 3 833 tests  3 460 ✅  1 💤 372 ❌
73 083 runs  72 303 ✅ 18 💤 762 ❌

For more details on these failures, see this check.

Results for commit 22a84ec.

♻️ This comment has been updated with latest results.

@dpiparo dpiparo closed this Dec 18, 2025
@dpiparo dpiparo reopened this Dec 18, 2025
@dpiparo dpiparo closed this Apr 10, 2026
@dpiparo dpiparo reopened this Apr 10, 2026
They were picked up as side effects of classes, but not forward declared as
and by themselves. This fixes namespaces and enums not being available / known
at the ROOT prompt despite their dictionary being loaded:
https://root-forum.cern.ch/t/enum-in-namespace-not-available-after-loading-dictionary/45757
@guitargeek
guitargeek force-pushed the dict-fwd-decl-ns-td-enum branch from 22a84ec to 97a1d71 Compare July 20, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants