Skip to content

Add workflow_run condition to documentation (close #64)#65

Merged
mpadge merged 3 commits intoropensci-review-tools:mainfrom
danielvartan:docs/issue-64
Jan 27, 2026
Merged

Add workflow_run condition to documentation (close #64)#65
mpadge merged 3 commits intoropensci-review-tools:mainfrom
danielvartan:docs/issue-64

Conversation

@danielvartan
Copy link
Copy Markdown
Contributor

Related to #64.

Cheers!

Comment thread README.md Outdated
@mpadge
Copy link
Copy Markdown
Member

mpadge commented Jan 21, 2026

Thanks, but could you please modify in these ways:

  • We can't have the workflow cancel when previous workflow failed, for the 2 reasons that (1) pkgcheck is intended to report workflow failures, so actually needs to be run on genuine failures; and (2) I think that will lead to an eternal cancel cycle that will fail first, then eternally detect previous fail and never work
  • Please reduce the rather large code chunk to the minimal bits that could be added to make running conditional on finishing rcmdcheck workflow only, without the duplicated other bits?

I think that will effectively reduce the code to just your header section, but you'd also need to expand that to show how to add your condition while also keeping the previous on condition of being triggered on every push-to-main event 👍

@danielvartan
Copy link
Copy Markdown
Contributor Author

Thanks for your revision, @mpadge.

I've made all the changes you requested. Please let me know if everything looks good.

@danielvartan danielvartan requested a review from mpadge January 21, 2026 19:20
@mpadge mpadge merged commit cc27d8d into ropensci-review-tools:main Jan 27, 2026
1 of 2 checks passed
@mpadge
Copy link
Copy Markdown
Member

mpadge commented Jan 27, 2026

Thanks @danielvartan!

mpadge added a commit that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants