Refactor: Rename rossocortex → cortex + clean residual kagenti refs

[Ibrahim2595]

Summary

Follow-up to the Rossoctl rename. #485 merged the rename + go.sum fixes, but not the later rossocortex→cortex change; separately, .claude/skills files that landed on main after the branch still referenced kagenti.

• rossocortex → cortex (19 files): token-broker require github.com/rossoctl/rossocortex/authbridge/authlib → .../cortex/...; webhook image defaults + e2e ghcr.io/rossoctl/rossocortex/* → ghcr.io/rossoctl/cortex/*
• Residual kagenti → rossoctl in .claude/skills (9 files): /tmp/kagenti/* → /tmp/rossoctl/*, kagenti-operator-controller-manager → rossoctl-operator-controller-manager, brand

Verification

• go build ✅, go vet ✅, internal/webhook/config test ✅
• git grep clean of kagenti and rossocortex

Known cross-repo dependency

token-broker depends on github.com/rossoctl/cortex/authbridge/authlib, which resolves once cortex #680 merges and its authlib module publishes under the cortex path.

Related issue(s)

Related to #1972

[mrsabath]

Summary

The operator-side counterpart to cortex#680, and the content is faithful: token-broker require path github.com/rossoctl/rossocortex/authbridge/authlib → .../cortex/..., webhook image defaults + e2e refs ghcr.io/rossoctl/rossocortex/* → ghcr.io/rossoctl/cortex/*, and the residual kagenti → rossoctl cleanup in the 9 .claude/skills files (/tmp/kagenti/*, kagenti-operator-controller-manager, brand). Signed-off ✅; Build/Unit/Integration/Lint/CodeQL all green.

Requesting changes on one blocking item (the PR title).

Blocking

• verify-pr-title fails and blocks merge. ⚠️ Rename rossocortex → cortex + clean residual kagenti doesn't start with an allowed prefix (Build, Chore, CI, Docs, Feat, Fix, Perf, Refactor, Revert, Style, Test, Feature, Bug fix, Proposal, Breaking change, Other/Misc). Retitle, e.g. Refactor: Rename rossocortex → cortex + clean residual kagenti refs. Same required check as cortex#680.

Non-blocking (correctly scoped out by the author)

• E2E Tests fails on docker pull ghcr.io/rossoctl/cortex/authbridge-envoy:latest — the renamed cortex sidecar image isn't published yet. The reference is correctly renamed; this is the registry-publish gate tied to cortex#680 shipping its images, not a defect here.
• token-broker/go.sum heads-up: go.mod now requires github.com/rossoctl/cortex/authbridge/authlib, but go.sum has no matching checksum yet (it can't be regenerated until cortex publishes the cortex/authlib module path — gated on #680). This is harmless to this repo's CI because token-broker is a separate Go module that no operator CI job builds (verified: Build/Unit/Integration pass). Run go mod tidy in token-broker/ once cortex#680 lands + publishes.

Areas reviewed: Go module require path, image refs, .claude/skills residual-kagenti cleanup, CI (both failures traced end-to-end), commit conventions.
CI status: 2 failing — verify-pr-title (blocking, fix the title) and E2E Tests (cortex image-publish gate); Build/Unit/Integration/Lint/CodeQL/Trivy all passing.

[Ibrahim2595]

Fixed — retitled to Refactor: Rename rossocortex → cortex + clean residual kagenti refs so verify-pr-title passes. Applied the same Refactor: prefix to the other four follow-up PRs, since they hit the same required check: examples rossoctl/examples#735, cortex rossoctl/cortex#680, flagship rossoctl/rossoctl#2243, and context-guru rossoctl/context-guru#10. Thanks for pinning the exact allowed-prefix list — that resolves the title question left open on the earlier PRs.

Agreed on the non-blocking items:

• E2E docker pull ghcr.io/rossoctl/cortex/authbridge-envoy:latest → cortex image-publish gate; clears when #680 ships cortex's images.
• token-broker/go.sum → I'll go mod tidy in token-broker/ once cortex #680 publishes the cortex/authbridge/authlib module path. That step is itself gated on context-guru Refactor: Rename context-guru module path kagenti → rossoctl context-guru#10 (renames context-guru's module path, which currently blocks cortex's own go mod tidy). Confirmed no operator CI job builds token-broker, so it's harmless to this repo's gates in the meantime.

[mrsabath]

verify-pr-title is green now. The remaining E2E Tests failure is the unpublished cortex sidecar image (docker pull ghcr.io/rossoctl/cortex/authbridge-envoy:latest), gated on cortex #680 merging + tagging. token-broker's github.com/rossoctl/cortex/authbridge/authlib require will go mod tidy cleanly once cortex publishes that module path. No further code change needed here beyond that ordering — see the rollout status on rossoctl/rossoctl#1972.

[mrsabath]

Re-reviewed. My earlier blocker (the ⚠️ title) is resolved — verify-pr-title is green, and the rossocortex → cortex rename + residual-kagenti cleanup in .claude/skills are faithful. Clearing my REQUEST_CHANGES.

Two things the merger should know (neither is a code defect in this PR):

• E2E Tests is still red, but that run is stale — it ran at 17:50, before cortex #680 merged (19:23), and fails on docker pull ghcr.io/rossoctl/cortex/authbridge-envoy:latest. The cortex sidecar images still aren't published: cortex #680 is merged but not yet tagged, so no ghcr.io/rossoctl/cortex/* packages exist. E2E can't pass until cortex is tagged v* and those packages are set Public (new GHCR packages default private → the anonymous docker pull 403s). Re-running E2E now won't help until then.

• token-broker/go.mod follow-up: it still pins a pre-rename cortex commit — github.com/rossoctl/cortex/authbridge/authlib v0.0.0-20260619001334-ce3417655ee8. Now that #680 landed the cortex module path, a go mod tidy in token-broker/ should bump this to a post-#680 cortex commit and regenerate go.sum. It's harmless to this repo's CI (no operator CI job builds token-broker), but worth doing before anything consumes it.

Approving on the understanding that the merge/tag sequence (cortex tag → set packages Public → re-run operator E2E) is tracked on rossoctl/rossoctl#1972.

Areas reviewed: Go module require path, image refs, .claude/skills cleanup, CI (E2E traced), commit conventions.
CI status: verify-pr-title green; E2E Tests red (stale run; downstream-gated on cortex tag+publish); all else passing.