Bump Oracle Instant Client to the latest versions#275
Merged
Conversation
Mirror rsim/oracle-enhanced#2621 for the ruby-plsql CI workflows: - Switch the modern (23.x) workflows to Oracle's version-less Instant Client download URLs so we automatically pick up new 23.x minors. ORACLE_HOME / LD_LIBRARY_PATH / PATH are derived dynamically from the extracted directory. - Bump the 11g compatibility workflows from 21.15.0.0.0dbru to 21.21.0.0.0dbru (latest 21.x; Oracle does not publish a version-less 21.x URL, so this line still requires an explicit pin). - Drop the redundant /jdbc/23261/ojdbc{11,17}.jar wgets where the Instant Client zip already ships the matching driver. The remaining download is test_11g.yml's ojdbc17.jar, because the 21.x zip does not include ojdbc17.jar and Oracle has no version-less JDBC URL.
After bumping the 11g matrix to Instant Client 21.21 and switching to ojdbc11.jar shipped inside that zip, the driver raises "Java::JavaSql::SQLException: Closed Resultset: next" when fetching from a closed cursor (lowercase 's' in "Resultset"). The previous ojdbc11 23.26 used "Closed ResultSet" (uppercase 'S') which the spec's regex matched. Add the /i flag so both casings — and any future case variant of the same message — match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror rsim/oracle-enhanced#2621 for the ruby-plsql CI workflows:
test,ruby_head,jruby_head,truffleruby,test_gemfiles) to Oracle's version-less Instant Client download URLs so we automatically pick up new 23.x minors.ORACLE_HOME/LD_LIBRARY_PATH/PATHare derived dynamically from the extracted directory, so the workflows no longer hard-codeinstantclient_23_26.test_11g,test_11g_ojdbc11) from21.15.0.0.0dbruto21.21.0.0.0dbru(latest 21.x). Oracle does not publish a version-less 21.x URL, so this line still requires an explicit pin. The inlineORA_TZFILEcomment was reworded so it does not stale on future bumps./jdbc/23261/ojdbc{11,17}.jarwgets where the Instant Client zip already ships the matching driver (test.yml,jruby_head.yml,test_11g_ojdbc11.yml). The single download that remains istest_11g.yml'sojdbc17.jar, because the 21.x zip does not includeojdbc17.jarand Oracle has no version-less JDBC URL.Test plan
testmatrix passes with the version-less 23.x downloadtest_11gmatrix passes against the new21.21.0.0.0dbrupintest_11g_ojdbc11passes with thecp $ORACLE_HOME/ojdbc11.jarshortcuttest_gemfilespassesruby_head,jruby_head,truffleruby) exercise the version-less 23.x download after merge