Skip to content

Fix/century pump light #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tagyoureit merged 2 commits into from
Apr 17, 2026
+15 −2
Merged

Fix/century pump light #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49550be
Enhance pump status determination for modbus and relay-based pumps
celestinjr Apr 10, 2026
72fdfed
Remove regalmodbus2 reference and console.debug statement
celestinjr Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions scripts/pumps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,21 @@
el.css({ display: '' });
if (data.pumpOnDelay === true)
el.find('div.picIndicator').attr('data-status', 'delay');
else
el.find('div.picIndicator').attr('data-status', data.command === 10 || data.relay > 0 ? 'on' : 'off');
else {
// Determine pump on/off status based on pump type
var isOn = false;
if (type.name === 'regalmodbus') {
// For modbus pumps, use actual speed/flow indicators
// Pump is considered "on" if it's actually running at a speed > 0
isOn = (typeof data.rpm !== 'undefined' && data.rpm > 0) ||
(typeof data.speed !== 'undefined' && data.speed > 0);
}
else {
// For relay-based pumps, use command or relay status
isOn = data.command === 10 || data.relay > 0;
}
el.find('div.picIndicator').attr('data-status', isOn ? 'on' : 'off');
}
}
el.attr('data-pumptype', data.type.val);
el.attr('data-id', data.id);
Expand Down